Skip to content

Use Rotations.jl #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JeffFessler opened this issue Oct 16, 2022 · 2 comments
Closed

Use Rotations.jl #59

JeffFessler opened this issue Oct 16, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@JeffFessler
Copy link
Member

Per example in #56 it seems we might want to switch to using Rotations.jl instead of home-brew.

We might also consider https://github.com/JuliaGeometry/CoordinateTransformations.jl, though that unfortunately has its own LinearMap type and probably is overkill for simple translation and scaling.
@JeffFessler JeffFessler added the enhancement New feature or request label Oct 16, 2022
@tknopp
Copy link
Member

tknopp commented Oct 16, 2022

I also thought about using Rotations.jl in #58 but kept it out in the first iteration in order to not increase the number of dependencies. One has to say that it pulls in StaticArrays.jl, which is a 1s using time dependency. If we just use that single rotation matrix (being a three liner) it is thus not clear to me if the reduction in code duplication is really worth it.

@JeffFessler
Copy link
Member Author

Agreed. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tknopp @JeffFessler