Skip to content

Review parametrization of geometries #1096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
juliohm opened this issue Oct 3, 2024 · 0 comments · Fixed by #1098
Closed

Review parametrization of geometries #1096

juliohm opened this issue Oct 3, 2024 · 0 comments · Fixed by #1098
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@juliohm
Copy link
Member

juliohm commented Oct 3, 2024 •
edited
Loading

The parametrizations were written before explicit support for CRS. We can probably do better now to construct the appropriate CRS type for the geometry and then call geometric transforms to position the points.

For example, in a Cylinder we can use Cylindrical coords, Rotation and Translation to find the final point.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
1 participant
@juliohm