Remove More Dead Code (#220)

* Bump patch

* Remove more dead code

Author: willtebbutt

Project.toml

@@ -1,6 +1,6 @@
 name = "Stheno"
 uuid = "8188c328-b5d6-583d-959b-9690869a5511"
-version = "0.7.17"
+version = "0.7.18"
 
 [deps]
 AbstractGPs = "99985d1d-32ba-4be9-9821-2ec096f28918"

src/Stheno.jl

@@ -35,7 +35,7 @@ module Stheno
     # Various bits of utility that aren't inherently GP-related. Often very type-piratic.
     include(joinpath("util", "zygote_rules.jl"))
     include(joinpath("util", "covariance_matrices.jl"))
-    include(joinpath("util", "dense.jl"))
+    include(joinpath("util", "block_arrays.jl"))
     include(joinpath("util", "abstract_data_set.jl"))
     include(joinpath("util", "proper_type_piracy.jl"))
 

src/util/block_arrays.jl

@@ -0,0 +1,25 @@
+# This file contains a number of additions to BlockArrays.jl. These are completely
+# independent of Stheno.jl, and will (hopefully) move over to BlockArrays.jl at some point.
+
+function ChainRulesCore.rrule(::typeof(BlockArrays.mortar), _blocks::AbstractArray)
+    y = BlockArrays.mortar(_blocks)
+    Ty = typeof(y)
+    function mortar_pullback(Δ::Tangent)
+        return (NoTangent(), Δ.blocks)
+    end
+    function mortar_pullback(Δ::BlockArray)
+        return mortar_pullback(Tangent{Ty}(; blocks = Δ.blocks, axes=NoTangent()))
+    end
+    return y, mortar_pullback  
+end
+
+# A hook to which I can attach an rrule without commiting type-piracy against BlockArrays.
+_collect(X::BlockArray) = Array(X)
+
+function ChainRulesCore.rrule(::typeof(_collect), X::BlockArray)
+    function Array_pullback(Δ::Array)
+        ΔX = Tangent{Any}(blocks=BlockArray(Δ, axes(X)).blocks, axes=NoTangent())
+        return (NoTangent(), ΔX)
+    end
+    return Array(X), Array_pullback
+end

src/util/dense.jl

@@ -34,8 +34,7 @@ using Stheno:
     diag_At_A,
     diag_At_B,
     diag_Xt_invA_X,
-    diag_Xt_invA_Y,
-    blocksizes
+    diag_Xt_invA_Y
 
 using Stheno.AbstractGPs.TestUtils: test_internal_abstractgps_interface
 using Stheno.AbstractGPs.Distributions: MvNormal
@@ -55,7 +54,7 @@ include("test_util.jl")
     @timedtestset "util" begin
         include(joinpath("util", "zygote_rules.jl"))
         include(joinpath("util", "covariance_matrices.jl"))
-        include(joinpath("util", "dense.jl"))
+        include(joinpath("util", "block_arrays.jl"))
         include(joinpath("util", "abstract_data_set.jl"))
     end