Skip to content

Fix erase! use in gcn.jl #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix erase! use in gcn.jl #707

wants to merge 1 commit into from

Conversation

gbaraldi
Copy link
Member

@gbaraldi gbaraldi commented Jul 1, 2025

This was probably a typo when LLVM.jl moved to using erase! using find and replace

This was probably a typo when LLVM.jl moved to using erase! using find and replace
@gbaraldi gbaraldi requested a review from maleadt July 1, 2025 21:16
Copy link
Contributor

github-actions bot commented Jul 1, 2025

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic master) to apply these changes.

Click here to view the suggested changes.
diff --git a/src/gcn.jl b/src/gcn.jl
index 36165a2..1f32d46 100644
--- a/src/gcn.jl
+++ b/src/gcn.jl
@@ -87,7 +87,7 @@ function lower_throw_extra!(mod::LLVM.Module)
                     # remove the call
                     nargs = length(parameters(f))
                     call_args = arguments(call)
-                    erase!(call)
+                        erase!(call)
 
                     # HACK: kill the exceptions' unused arguments
                     for arg in call_args

@vchuravy
Copy link
Member

vchuravy commented Jul 2, 2025

Duplicate of #706

@vchuravy vchuravy marked this as a duplicate of #706 Jul 2, 2025
@vchuravy vchuravy closed this Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants