Skip to content

Change rethrow(e) to rethrow() #2736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 6, 2025
Merged

Change rethrow(e) to rethrow() #2736

merged 2 commits into from
Jun 6, 2025

Conversation

DilumAluthge
Copy link
Contributor

We don't need to do rethrow(e), because rethrow() will correctly rethrow the caught exception.

fredrikekre
fredrikekre reviewed Jun 4, 2025
View reviewed changes
Copy link
Member

@fredrikekre fredrikekre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to capture the error in the e variable either now.

@mortenpi mortenpi added Type: Maintenance Skip Changelog Allows the CHANGELOG.md check to pass without edit to the file. labels Jun 4, 2025
@DilumAluthge
Copy link
Contributor Author

No need to capture the error in the e variable either now.

Done in 2fd702e

@mortenpi
Copy link
Member

mortenpi commented Jun 6, 2025

Thank you!

@mortenpi mortenpi merged commit 25f9027 into JuliaDocs:master Jun 6, 2025
21 of 26 checks passed
@DilumAluthge DilumAluthge deleted the dpa/rethrow branch June 6, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredrikekre fredrikekre fredrikekre left review comments

Assignees
No one assigned
Labels
Skip Changelog Allows the CHANGELOG.md check to pass without edit to the file. Type: Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DilumAluthge @mortenpi @fredrikekre