Skip to content

Commit 97bbb40

Browse files
sprigbkamins
andauthored
Update filter docs, Fixes #3460 (#3461)
* Update filter docs * Apply suggestions from code review --------- Co-authored-by: Bogumił Kamiński <[email protected]>
1 parent bb63361 commit 97bbb40

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

src/abstractdataframe/abstractdataframe.jl

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1151,6 +1151,11 @@ data frames.
11511151
function instead as it is consistent with other DataFrames.jl functions
11521152
(as opposed to `filter`).
11531153
1154+
!!! note
1155+
1156+
Due to type stability the `filter(cols => fun, df::AbstractDataFrame; view::Bool=false)`
1157+
call is preferred in performance critical applications.
1158+
11541159
$METADATA_FIXED
11551160
11561161
See also: [`filter!`](@ref)
@@ -1281,6 +1286,11 @@ data frames.
12811286
function instead as it is consistent with other DataFrames.jl functions
12821287
(as opposed to `filter!`).
12831288
1289+
!!! note
1290+
1291+
Due to type stability the `filter!(cols => fun, df::AbstractDataFrame)`
1292+
call is preferred in performance critical applications.
1293+
12841294
$METADATA_FIXED
12851295
12861296
See also: [`filter`](@ref)

0 commit comments

Comments
 (0)