feat(validate): expand errors to include field name #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds changes the `errors` array that's returned from `validate` to be an array of objects that includes `field` and `message`, so that each error message is associated with which field the error applies to. Question: is there value in doing similar for `warnings` and `recommendations`? I'm thinking not, since the presence of those won't make the overall result invalid (whereas `errors` does result in an invalid result), but i'm certainly open to applying the same to those for consistency. BREAKING CHANGE
michaelfaith
force-pushed
the
feat/field-info-with-errors
branch
from
cc56111 to
e032584
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
This change adds changes the
errorsarray that's returned fromvalidateto be an array of objects that includesfieldandmessage, so that each error message is associated with which field the error applies to.errorsis now of typeValidationError[]whereValidationErrorisQuestion: is there value in doing similar for
warningsandrecommendations? I'm thinking not, since the presence of those won't make the overall result invalid (whereaserrorsdoes result in an invalid result), but i'm certainly open to applying the same to those for consistency.BREAKING CHANGE