Skip to content

🚀 Feature: Create valid-module #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 tasks done
michaelfaith opened this issue May 3, 2025 · 0 comments
Open
2 tasks done

🚀 Feature: Create valid-module #1034

michaelfaith opened this issue May 3, 2025 · 0 comments
Labels
type: feature New enhancement or request 🚀
Milestone

Comments

@michaelfaith
Copy link
Collaborator

Feature Request Checklist

Overview

Following #42 -> #51: we've resolved to create a standalone valid-man rule. It should enforce that, if the field exists in the package.json file, it's set to a valid value. It should do nothing if the field doesn't exist. Per #850, this should be included in the recommended config.

Additional Info

For this issue, we should:

  1. Send a PR to create the rule in this repo (resolving this issue)
  2. File an issue on https://github.com/JoshuaKGoldberg/package-json-validator to create a standalone API that performs the same validation
  3. Once a version of package-json-validator is released with that feature, file an issue on this repo to switch the rule to use that API from package-json-validator

If you want to take on just step 1, that's ok - no pressure to do all three. 🙂

Once all valid- rules exist in this plugin, we can then file an issue to deprecate the valid-package-def rule in favor of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New enhancement or request 🚀
Projects
None yet
Development

No branches or pull requests

1 participant