Skip to content

Commit ddd8e3a

Browse files
StefanStojanovicJonasBa
authored andcommitted
win: fix SIGQUIT on ClangCL
PR-URL: nodejs#57659 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent eaf7eba commit ddd8e3a

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

src/node.h

+2-1
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,8 @@
6767
#endif
6868

6969
#ifdef _WIN32
70-
# define SIGKILL 9
70+
#define SIGQUIT 3
71+
#define SIGKILL 9
7172
#endif
7273

7374
#include "v8.h" // NOLINT(build/include_order)

test/parallel/test-child-process-kill.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,7 @@ assert.strictEqual(cat.killed, true);
4242

4343
// Test different types of kill signals on Windows.
4444
if (common.isWindows) {
45-
// SIGQUIT is not supported on Windows 2022, Visual Studio 2022 ClangCL-produced node.exe.
46-
// TODO(StefanStojanovic): Investigate this and re-enable it when the issue is fixed.
47-
for (const sendSignal of ['SIGTERM', 'SIGKILL', /* 'SIGQUIT', */'SIGINT']) {
45+
for (const sendSignal of ['SIGTERM', 'SIGKILL', 'SIGQUIT', 'SIGINT']) {
4846
const process = spawn('cmd');
4947
process.on('exit', (code, signal) => {
5048
assert.strictEqual(code, null);

0 commit comments

Comments
 (0)