Skip to content

ReSharper Unity Support extension is incompatible with R# 2022.2.2 #2354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aybe opened this issue Sep 3, 2022 · 7 comments
Closed

ReSharper Unity Support extension is incompatible with R# 2022.2.2 #2354

aybe opened this issue Sep 3, 2022 · 7 comments
Assignees

Comments

@aybe
Copy link

aybe commented Sep 3, 2022

Even though the extension can be installed from the menu, once Visual Studio is restarted, it is flagged as incompatible.

How can I get the Unity Support extension to work?

ReSharper 2022.2.20220820.133634
Unity Support 2022.2.0.143
Visual Studio 2022 (64-bit) Version 17.3.3

Thank you

@Fijit
Copy link

Fijit commented Sep 4, 2022

I have the same issue as @aybe - same versions of R# and VS.

I wondered why namespaces were still being called out before noticing that the extension wasn't actually active due to incompatibility.

@tgoessler
Copy link

The same for me.
Is there a new build planned for Resharper 2022.2.20220820.133634?

@AntiSilence
Copy link

Having the same issue @citizenmatt

1

@citizenmatt
Copy link
Member

Sorry folks. I've been out of office and not able to look at this properly. There is an issue with 2022.2.2, and we're currently investigating. I expect we'll have something sorted very soon, in the next day or two. In the meantime, ReSharper 2022.2.1 will work with the Unity plugin.

The issue is related to the new extension API verifier. The idea is that we can load extensions built for older versions of ReSharper without having to recompile for each release, as long as the API is compatible. The installer will run the verifier over the extension at install/update time and if all is well, allow the extension to load. If there's a problem, the extension is marked as incompatible and blocked.

Unfortunately, the verifier doesn't handle the scenario of optional dependencies, and the Unity plugin has an optional dependency on ReSharper C++ for shader file support. Previously, the installer would show some warnings if ReSharper C++ was not installed, but everything would work at runtime, because ReSharper's component container sees that our shader support assembly requires a product feature that's not installed, and doesn't load any of those components. The API verifier doesn't have this information (it's a concept that's baked into the component container), and so the API verifier only sees an assembly in the extension that has unresolved dependencies on the types in ReSharper C++. This is easily worked around by installing ReSharper C++.

However, there's a problem with ReSharper 2022.2.2. The API verifier is marking the plugin as incompatible, even if ReSharper C++ is installed. Right now, I'm not sure what's going on, and I'm chatting to the developer in charge of the API verifier to see what's up. Hopefully we'll be able to quickly figure out what's wrong and fix it with a new build of the plugin.

Apologies again, and thanks for your patience.

@citizenmatt citizenmatt changed the title Unity Support extension is incompatible ReSharper Unity Support extension is incompatible with R# 2022.2.2 Sep 6, 2022
@citizenmatt
Copy link
Member

Bad news, I'm afraid. We've figured out what's going wrong, and it's not something that we'll be able to fix solely in the plugin. It requires a change in both the plugin (#2346) and the API verifier, which we'll do for 2022.2.3, which is due in the next week or two. In the meantime, 2022.2.1 will continue to work. Apologies again.

@citizenmatt citizenmatt self-assigned this Sep 6, 2022
@citizenmatt citizenmatt added this to the Rider 2022.2.3 milestone Sep 6, 2022
@AntiSilence
Copy link

Thank you for the update @citizenmatt 👍

@citizenmatt citizenmatt linked a pull request Sep 7, 2022 that will close this issue
@aybe
Copy link
Author

aybe commented Sep 7, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants