Set up proper visibility (api/implementation) between dependencies of subprojects

Author: dmitrii-artuhov

build.gradle.kts

@@ -135,9 +135,9 @@ sourceSets {
         val atomicfuVersion: String by project
 
         compileOnly(project(":bootstrap"))
-        api(project(":jvm-agent"))
-        api(project(":common"))
-        api(project(":trace"))
+        api(project(":common")) // TODO: contains some classes from public lincheck API, refactor so that it does not expose essentially internal classes
+        implementation(project(":jvm-agent"))
+        implementation(project(":trace"))
 
         api("org.jetbrains.kotlin:kotlin-stdlib:$kotlinVersion")
         api("org.jetbrains.kotlin:kotlin-stdlib-common:$kotlinVersion")

jvm-agent/build.gradle.kts

@@ -22,7 +22,7 @@ sourceSets {
         val byteBuddyVersion: String by project
 
         compileOnly(project(":bootstrap"))
-        api(project(":common"))
+        implementation(project(":common"))
 
         api("org.jetbrains.kotlin:kotlin-stdlib:${kotlinVersion}")
         api("org.jetbrains.kotlin:kotlin-stdlib-common:${kotlinVersion}")

src/jvm/test/org/jetbrains/kotlinx/lincheck_test/representation/InlineExtFuncRepresentationTest.kt

@@ -10,7 +10,7 @@
 
 package org.jetbrains.kotlinx.lincheck_test.representation
 
-import org.jetbrains.kotlinx.lincheck.traceagent.isInTraceDebuggerMode
+import org.jetbrains.kotlinx.lincheck.util.isInTraceDebuggerMode
 import org.jetbrains.kotlinx.lincheck.util.isJdk8
 import org.junit.Assume.assumeFalse
 import org.junit.Before
@@ -24,7 +24,7 @@ class InlineExtFuncRepresentationTest: BaseTraceRepresentationTest("inline_ext_f
         // cannot run this test, as it has different output on JDK-8,
         // but due to https://github.com/JetBrains/lincheck/issues/500
         // we cannot set trace-debugger & JDK-8 specific expected output file
-        assumeFalse(isInTraceDebuggerMode)
+        assumeFalse(isInTraceDebuggerMode || isJdk8)
     }
 
     @Suppress("NOTHING_TO_INLINE")

trace-debugger/build.gradle.kts

@@ -25,8 +25,9 @@ sourceSets {
         val byteBuddyVersion: String by project
 
         compileOnly(project(":bootstrap"))
-        api(project(":"))
-        api(project(":jvm-agent"))
+        implementation(project(":"))
+        implementation(project(":common"))
+        implementation(project(":jvm-agent"))
 
         api("org.jetbrains.kotlin:kotlin-stdlib:${kotlinVersion}")
         api("org.jetbrains.kotlin:kotlin-stdlib-common:${kotlinVersion}")

trace-recorder/build.gradle.kts

@@ -25,9 +25,9 @@ sourceSets {
         val byteBuddyVersion: String by project
 
         compileOnly(project(":bootstrap"))
-        api(project(":common"))
-        api(project(":jvm-agent"))
-        api(project(":trace"))
+        implementation(project(":common"))
+        implementation(project(":jvm-agent"))
+        implementation(project(":trace"))
 
         api("org.jetbrains.kotlin:kotlin-stdlib:${kotlinVersion}")
         api("org.jetbrains.kotlin:kotlin-stdlib-common:${kotlinVersion}")