Async keyword is not part of the public API #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SeanFeldman feel free to review |
|
Tested with NServiceBus Particular/NServiceBus@154d2ee#diff-1eb180a4f6d35cd0c53fde55c1a077b3L337 |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19
The async keyword should not be part of the public API at all.
The async keyword is an implementation detail since it is just syntactic sugar. From an API perspective the following APIs are equivalent:
async voidvs.voidasync TaskvsTaskasync Task<T>vsTask<T>From a behavior perspective you could argue that the runtime behavior from
voidtoasync voidcan change and therefore it could be a breaking change but from an API perspective both APIs are binary compatible. Since API approver's concern is only the public API theasynckeyword should be omitted.