PublicApiGenerator made source only package #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumped version to 5.0 CecilEx.cs moved into ApiGenerator Renamed PublicApiGenerator to ApiGenerator to not clash with namespace
|
@JakeGinnivan @danielmarbach, what was the reason for this change? |
|
The reason for this change is signing. With AppPackages the code is signed with the project settings of the target it is pulled in. Otherwise we'd need to sign the generator with a strong name for strong named test assemblies or provide both signed or unsigned versions. Resharper analysis allows to ignore all files in AppPackages folder. Sure stylecop can do this too?
… Am 02.01.2017 um 01:42 schrieb Thomas Levesque ***@***.***>:
@JakeGinnivan @danielmarbach, what was the reason for this change?
I don't know what are the benefits of making it a source-only package, but I know the drawbacks... We use PublicApiGenerator as a binary package in FakeItEasy, and when I tried to upgrade to the latest version, I was greeted with dozens of StyleCop warnings, which I can't easily disable. Would it be possible to maintain a binary package as well as a source-only package?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Probably, but I haven't figured out how to do it yet... |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded NSB here Particular/NServiceBus#4273
Thoughts @SimonCropp @andreasohlund @JakeGinnivan ?