Skip to content

Implement escaping for keyword separators #12810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
koppor opened this issue Mar 23, 2025 · 13 comments · May be fixed by #12888
Open

Implement escaping for keyword separators #12810

koppor opened this issue Mar 23, 2025 · 13 comments · May be fixed by #12888
Assignees
@krishnagjsForGit
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. 📌 Pinned

Comments

@koppor
Copy link
Member

koppor commented Mar 23, 2025

Context: #12532 (comment)

JabRef does not support \ to be used as escaping for the keyword separator

Task:

  1. Add test cases for \, in org.jabref.model.entry.KeywordListTest
  2. Adapt org.jabref.model.entry.KeywordList#parse(java.lang.String, java.lang.Character, java.lang.Character) to implement the escaping
@koppor koppor added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Mar 23, 2025
@github-project-automation github-project-automation bot moved this to Free to take in Good First Issues Mar 23, 2025
@koppor koppor mentioned this issue Mar 23, 2025
Open
@krishnagjsForGit
Copy link

Hi, I am new to Opensource. I want to start my work on this. Can I work on this?

@krishnagjsForGit
Copy link

/assign-me

@github-actions github-actions bot added the 📍 Assigned Assigned by assign-issue-action (or manually assigned) label Mar 24, 2025
@github-actions GitHub Actions
Copy link
Contributor

👋 Hey @krishnagjsForGit, thank you for your interest in this issue! 🎉

We're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

⏳ Please note, you will be automatically unassigned if there is not a (draft) pull request within 14 days (by 07 April 2025).

@koppor koppor moved this from Free to take to Assigned in Good First Issues Mar 24, 2025
krishnagjsForGit pushed a commit to krishnagjsForGit/jabref that referenced this issue Apr 6, 2025
Fix for issue JabRef#12810
ddffe9b
@krishnagjsForGit
Copy link

Kindly Find the PR : krishnagjsForGit#1

@koppor koppor moved this from Assigned to In Progress in Good First Issues Apr 6, 2025
@krishnagjsForGit krishnagjsForGit linked a pull request Apr 6, 2025 that will close this issue
Draft
4 tasks
Rajas55 added a commit to Rajas55/jabref that referenced this issue Apr 20, 2025
@Rajas55
Fix JabRef#12810: Add escaping for keyword separators in KeywordList
1c99753
Rajas55 added a commit to Rajas55/jabref that referenced this issue Apr 20, 2025
@Rajas55
Update CHANGELOG.md for JabRef#12810
e089754
@Rajas55 Rajas55 mentioned this issue Apr 20, 2025
Closed
4 tasks
@Rajas55
Copy link

Rajas55 commented Apr 20, 2025

I'm working on this issue. Please assign it to me. PR: #12810

@github-actions GitHub Actions
Copy link
Contributor

⚠️ Issue Already Assigned

Hi @Rajas55, this issue is currently assigned to @krishnagjsForGit.

Note

If no progress is made within 14 days, the issue will be automatically unassigned.

Options for contributors
  • Wait for availability: The issue may become available if auto-unassigned
  • Collaborate: You can ask the assignee if they want help
  • Maintainer assistance: A maintainer can add you as co-assignee if appropriate

@Rajas55
Copy link

Rajas55 commented Apr 20, 2025

PR opened to fix this in #12833. Please review when possible 🙂

@krishnagjsForGit
Copy link

PR opened to fix this in #12833. Please review when possible 🙂

Already issue is being worked upon. And PR review is on progress. Why duplicate the efforts?

@koppor
Copy link
Member Author

koppor commented Apr 22, 2025

PR opened to fix this in #12833. Please review when possible 🙂

Wrong link. Please link the issue from the PR

1 similar comment
@koppor
Copy link
Member Author

koppor commented Apr 22, 2025

PR opened to fix this in #12833. Please review when possible 🙂

Wrong link. Please link the issue from the PR

Rajas55 added a commit to Rajas55/jabref that referenced this issue Apr 23, 2025
@Rajas55
fix: escape keyword delimiters and prevent paste-to-search [JabRef#12810
bb984f1 
][JabRef#12910]
@subhramit
Copy link
Member

subhramit commented May 2, 2025 •
edited
Loading

PR opened to fix this in #12833. Please review when possible 🙂

@Rajas55 Are you not able to read that someone else is assigned and working on this issue already?

@github-actions github-actions bot removed the 📍 Assigned Assigned by assign-issue-action (or manually assigned) label May 2, 2025
@subhramit subhramit added the 📍 Assigned Assigned by assign-issue-action (or manually assigned) label May 2, 2025
@koppor koppor moved this from In Progress to Assigned in Good First Issues May 2, 2025
@koppor koppor moved this from Assigned to In Progress in Good First Issues May 2, 2025
@github-actions github-actions bot removed 📍 Assigned Assigned by assign-issue-action (or manually assigned) 📌 Pinned labels May 3, 2025
@koppor koppor moved this from In Progress to Free to take in Good First Issues May 3, 2025
@koppor koppor moved this from Free to take to In Progress in Good First Issues May 3, 2025
@Harshavardhan-prog
Copy link

Hi! I'm a beginner in open source and Java, and I'd like to work on this issue as my first contribution. Can I take this up?

@subhramit
Copy link
Member

Hi! I'm a beginner in open source and Java, and I'd like to work on this issue as my first contribution. Can I take this up?

Hi, welcome to JabRef. Unfortunately, @krishnagjsForGit is already assigned to the issue. You can check if an issue is assigned to somebody by looking at the right side column:

Image

You may pick any other first issue you like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krishnagjsForGit krishnagjsForGit

Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. 📌 Pinned
Projects
Good First Issues
Status: In Progress
Milestone
No milestone
5 participants
@koppor @krishnagjsForGit @subhramit @Rajas55 @Harshavardhan-prog