Move event processing from source tab into entry editor (#3116)

Author: lenhard

CHANGELOG.md

@@ -16,6 +16,7 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `#
 - Added 'Filter All' and 'Filter None' buttons with corresponding functionality to Quality Check tool.  
 
 ### Fixed
+ - We fixed a memory leak in the source tab of the entry editor [#3113](https://github.com/JabRef/jabref/issues/3113)
 
 ### Removed
 

src/main/java/org/jabref/gui/entryeditor/EntryEditor.java

@@ -77,6 +77,7 @@
 import org.jabref.model.database.BibDatabase;
 import org.jabref.model.entry.BibEntry;
 import org.jabref.model.entry.EntryType;
+import org.jabref.model.entry.event.EntryChangedEvent;
 import org.jabref.model.entry.event.FieldAddedOrRemovedEvent;
 import org.jabref.preferences.JabRefPreferences;
 
@@ -225,6 +226,11 @@ public synchronized void listen(FieldAddedOrRemovedEvent event) {
         }
     }
 
+    @Subscribe
+    public synchronized void listen(EntryChangedEvent event) {
+        sourceTab.updateSourcePane();
+    }
+
     private void rebuildOtherFieldsTab() {
         int index = -1;
         boolean isOtherFieldsTabSelected = false;
@@ -526,9 +532,6 @@ public void setMovingToDifferentEntry() {
 
     private void unregisterListeners() {
         this.entry.unregisterListener(this);
-        if (sourceTab != null) {
-            this.sourceTab.deregisterListeners();
-        }
         removeSearchListeners();
 
     }

src/main/java/org/jabref/gui/entryeditor/SourceTab.java

@@ -29,9 +29,7 @@
 import org.jabref.model.database.BibDatabaseMode;
 import org.jabref.model.entry.BibEntry;
 import org.jabref.model.entry.InternalBibtexFields;
-import org.jabref.model.entry.event.EntryChangedEvent;
 
-import com.google.common.eventbus.Subscribe;
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
 import org.fxmisc.easybind.EasyBind;
@@ -52,7 +50,6 @@ public SourceTab(BasePanel panel, BibEntry entry, BooleanProperty movingToDiffer
         this.entry = entry;
         this.panel = panel;
         this.movingToDifferentEntry = movingToDifferentEntry;
-        panel.getBibDatabaseContext().getDatabase().registerListener(this);
         this.setText(Localization.lang("%0 source", mode.getFormattedName()));
         this.setTooltip(new Tooltip(Localization.lang("Show/edit %0 source", mode.getFormattedName())));
         this.setGraphic(IconTheme.JabRefIcon.SOURCE.getGraphicNode());
@@ -67,26 +64,17 @@ private static String getSourceString(BibEntry entry, BibDatabaseMode type) thro
         return stringWriter.getBuffer().toString();
     }
 
-    @Subscribe
-    public void listen(EntryChangedEvent event) {
-        if (codeArea != null && this.entry.equals(event.getBibEntry())) {
-            DefaultTaskExecutor.runInJavaFXThread(() -> updateSourcePane());
-        }
-    }
-
-    public void deregisterListeners() {
-        this.entry.unregisterListener(this);
-    }
-
-    private void updateSourcePane() {
-        try {
-            codeArea.clear();
-            codeArea.appendText(getSourceString(entry, mode));
-        } catch (IOException ex) {
-            codeArea.appendText(ex.getMessage() + "\n\n" +
-                    Localization.lang("Correct the entry, and reopen editor to display/edit source."));
-            codeArea.setEditable(false);
-            LOGGER.debug("Incorrect entry", ex);
+    public void updateSourcePane() {
+        if (codeArea != null) {
+            try {
+                codeArea.clear();
+                codeArea.appendText(getSourceString(entry, mode));
+            } catch (IOException ex) {
+                codeArea.appendText(ex.getMessage() + "\n\n" +
+                        Localization.lang("Correct the entry, and reopen editor to display/edit source."));
+                codeArea.setEditable(false);
+                LOGGER.debug("Incorrect entry", ex);
+            }
         }
     }