test: improve and simplify assertion at test

otaviojava · otaviojava · commit ae2fcdbed183 · 2025-01-01T20:20:41.000Z
Signed-off-by: Otavio Santana &lt;otaviopolianasantana@gmail.com&gt;
diff --git a/bean-validation/src/test/java/org/jnosql/demo/se/validation/MonetaryAmountAcceptedValidatorTest.java b/bean-validation/src/test/java/org/jnosql/demo/se/validation/MonetaryAmountAcceptedValidatorTest.java
@@ -114,7 +114,7 @@ public void shouldReturnsConstrainsWhenCurrencyDenied(){
         Set<ConstraintViolation<MonetaryAmountValidator>> constraintViolations =
                 validator.validate(currency);
 
-        assertTrue(constraintViolations.size() == 1);
+        assertEquals(1, constraintViolations.size());
         assertEquals("{org.javamoney.midas.constraints.currencyAccepted}", constraintViolations.iterator().next().getMessageTemplate());
     }
 
diff --git a/bean-validation/src/test/java/org/jnosql/demo/se/validation/MonetaryAmountMaxValidatorTest.java b/bean-validation/src/test/java/org/jnosql/demo/se/validation/MonetaryAmountMaxValidatorTest.java
@@ -96,7 +96,7 @@ public void shouldReturnsConstrainsWhenMonetaryIsGreaterThanMaximum() {
         Set<ConstraintViolation<MonetaryAmountValidator>> constraintViolations =
                 validator.validate(currency);
 
-        assertTrue(constraintViolations.size() == 1);
+        assertEquals(1, constraintViolations.size());
         assertEquals("{org.javamoney.midas.constraints.monetaryMax}", constraintViolations.iterator().next().getMessageTemplate());
     }
 
diff --git a/bean-validation/src/test/java/org/jnosql/demo/se/validation/MonetaryAmountMinValidatorTest.java b/bean-validation/src/test/java/org/jnosql/demo/se/validation/MonetaryAmountMinValidatorTest.java
@@ -97,7 +97,7 @@ public void shouldReturnsConstrainsWhenMonetaryIsLesserThanMinimum() {
         Set<ConstraintViolation<MonetaryAmountValidator>> constraintViolations =
                 validator.validate(currency);
 
-        assertTrue(constraintViolations.size() == 1);
+        assertEquals(1, constraintViolations.size());
         assertEquals("{org.javamoney.midas.constraints.monetaryMin}", constraintViolations.iterator().next().getMessageTemplate());
     }
 

Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,7 @@ public void shouldReturnsConstrainsWhenCurrencyDenied(){`
`114`	`114`	`Set<ConstraintViolation<MonetaryAmountValidator>> constraintViolations =`
`115`	`115`	`validator.validate(currency);`
`116`	`116`
`117`		`- assertTrue(constraintViolations.size() == 1);`
	`117`	`+ assertEquals(1, constraintViolations.size());`
`118`	`118`	`assertEquals("{org.javamoney.midas.constraints.currencyAccepted}", constraintViolations.iterator().next().getMessageTemplate());`
`119`	`119`	`}`
`120`	`120`
Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ public void shouldReturnsConstrainsWhenMonetaryIsGreaterThanMaximum() {`
`96`	`96`	`Set<ConstraintViolation<MonetaryAmountValidator>> constraintViolations =`
`97`	`97`	`validator.validate(currency);`
`98`	`98`
`99`		`- assertTrue(constraintViolations.size() == 1);`
	`99`	`+ assertEquals(1, constraintViolations.size());`
`100`	`100`	`assertEquals("{org.javamoney.midas.constraints.monetaryMax}", constraintViolations.iterator().next().getMessageTemplate());`
`101`	`101`	`}`
`102`	`102`
Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,7 @@ public void shouldReturnsConstrainsWhenMonetaryIsLesserThanMinimum() {`
`97`	`97`	`Set<ConstraintViolation<MonetaryAmountValidator>> constraintViolations =`
`98`	`98`	`validator.validate(currency);`
`99`	`99`
`100`		`- assertTrue(constraintViolations.size() == 1);`
	`100`	`+ assertEquals(1, constraintViolations.size());`
`101`	`101`	`assertEquals("{org.javamoney.midas.constraints.monetaryMin}", constraintViolations.iterator().next().getMessageTemplate());`
`102`	`102`	`}`
`103`	`103`