Skip to content

reproducing for 5-datasets #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jcy132 opened this issue Jan 11, 2023 · 1 comment
Open

reproducing for 5-datasets #6

jcy132 opened this issue Jan 11, 2023 · 1 comment

Comments

@jcy132
Copy link

jcy132 commented Jan 11, 2023

I applied the implemented code for 5-datasets.
The result was acc@1 75.5033 | forgetting 14.9538,
which is much lower than the result in the paper, acc@1 88.08 | forgetting 2.21

any missed point?

@JH-LEE-KR
Copy link
Owner

Hi,
thanks for your comment.

I didn't implement and experiment,
because the dualprompt 5-datasets config of the official code was not opened.
Did you use L2P's 5-datasets config as it is?

In my experience, the dataset order (fixed order in official code) and use_prompt_mask have a significant impact on performance in 5-datasets.

Please check it and leave a comment.
Discuss it together.

Best,
Jaeho Lee.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants