Skip to content

Suggestion: add title attribute to ProPlate #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lucaswerkmeister opened this issue Jul 23, 2023 · 1 comment · Fixed by #73
Closed

Suggestion: add title attribute to ProPlate #71

lucaswerkmeister opened this issue Jul 23, 2023 · 1 comment · Fixed by #73

Comments

@lucaswerkmeister
Copy link

This would provide an additional way for users to read the pronouns in cases where the text content gets cut off.

Without title:
Screenshot from 2023-07-23 15-45-35

With title:
Screenshot from 2023-07-23 15-45-45

(Added via document.querySelectorAll('.protoots-proplate').forEach(el => { el.title = el.textContent; }).)

Admittedly, I’m not sure what the effect of this on screen reader users is… we don’t want screen readers to read out the plate twice, I suppose.

@lucaswerkmeister
Copy link
Author

There’s one more thing to notice in the screenshot: @theresnotime’s pronouns are “they/them” in the badge, but “They/Them” in the title. They’re specified as “They/Them” in the bio, but the badge has text-transform: lowercase; set in CSS. I’m not sure I agree with this transformation, tbh; but be that as it may – my simplistic implementation pasted above makes this a bit more visible, so if you want to keep the transform, you might want to also apply it to the title.

@ItsVipra ItsVipra linked a pull request Aug 1, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant