Skip to content

Commit fbee6d7

Browse files
akuegeltensorflower-gardener
authored andcommitted
Remove guards from gpu_lt_matmul_thunk target (NFC).
Those should not be necessary. PiperOrigin-RevId: 649579418
1 parent 35e0457 commit fbee6d7

File tree

3 files changed

+12
-19
lines changed

3 files changed

+12
-19
lines changed

third_party/xla/xla/service/gpu/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -355,6 +355,7 @@ cc_library(
355355
"//xla/service/gpu/runtime:fft_thunk",
356356
"//xla/service/gpu/runtime:fused_mha_thunk",
357357
"//xla/service/gpu/runtime:gemm_thunk",
358+
"//xla/service/gpu/runtime:gpublas_lt_matmul_thunk",
358359
"//xla/service/gpu/runtime:infeed_thunk",
359360
"//xla/service/gpu/runtime:kernel_thunk",
360361
"//xla/service/gpu/runtime:nccl_all_gather_thunk",
@@ -420,7 +421,6 @@ cc_library(
420421
"//xla/service/gpu/fusions",
421422
"//xla/service/gpu/runtime:cholesky_thunk",
422423
"//xla/service/gpu/runtime:cub_sort_thunk",
423-
"//xla/service/gpu/runtime:gpublas_lt_matmul_thunk",
424424
"//xla/service/gpu/runtime:triangular_solve_thunk",
425425
]) + if_rocm_is_configured([
426426
"@local_config_rocm//rocm:rocm_headers",

third_party/xla/xla/service/gpu/ir_emitter_unnested.cc

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,7 @@ limitations under the License.
123123
#include "xla/service/gpu/runtime/fft_thunk.h"
124124
#include "xla/service/gpu/runtime/fused_mha_thunk.h"
125125
#include "xla/service/gpu/runtime/gemm_thunk.h"
126+
#include "xla/service/gpu/runtime/gpublas_lt_matmul_thunk.h"
126127
#include "xla/service/gpu/runtime/infeed_thunk.h"
127128
#include "xla/service/gpu/runtime/kernel_thunk.h"
128129
#include "xla/service/gpu/runtime/nccl_all_gather_thunk.h"
@@ -167,10 +168,6 @@ limitations under the License.
167168
#include "tsl/protobuf/dnn.pb.h"
168169
#include "triton/Dialect/Triton/IR/Dialect.h"
169170

170-
#if GOOGLE_CUDA || TF_HIPBLASLT
171-
#include "xla/service/gpu/runtime/gpublas_lt_matmul_thunk.h"
172-
#endif // GOOGLE_CUDA || TF_HIPBLASLT
173-
174171
#if GOOGLE_CUDA || TENSORFLOW_USE_ROCM
175172
#include "xla/service/gpu/ir_emitter_triton.h"
176173
#include "xla/service/gpu/runtime/cholesky_thunk.h"

third_party/xla/xla/service/gpu/runtime/BUILD

Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -686,26 +686,22 @@ cc_library(
686686

687687
cc_library(
688688
name = "gpublas_lt_matmul_thunk",
689-
srcs = if_gpu_is_configured(["gpublas_lt_matmul_thunk.cc"]),
690-
hdrs = if_gpu_is_configured(["gpublas_lt_matmul_thunk.h"]),
691-
local_defines = if_cuda_is_configured(["GOOGLE_CUDA=1"]) + if_rocm_is_configured([
692-
"TENSORFLOW_USE_ROCM=1",
693-
]),
694-
deps = if_gpu_is_configured([
695-
"@com_google_absl//absl/base:core_headers",
696-
"@com_google_absl//absl/container:flat_hash_map",
697-
"@com_google_absl//absl/synchronization",
689+
srcs = ["gpublas_lt_matmul_thunk.cc"],
690+
hdrs = ["gpublas_lt_matmul_thunk.h"],
691+
deps = [
692+
"//xla:status_macros",
698693
"//xla/service:buffer_assignment",
694+
"//xla/service/gpu:buffer_allocations",
699695
"//xla/service/gpu:matmul_utils",
700696
"//xla/service/gpu/runtime:thunk",
701-
"//xla/stream_executor:device_memory",
702697
"//xla/stream_executor",
698+
"//xla/stream_executor:device_memory",
703699
"//xla/stream_executor/gpu:gpu_blas_lt",
704-
"@local_tsl//tsl/platform:logging",
705-
]) + [
706-
"//xla:status_macros",
707-
"//xla/service/gpu:buffer_allocations",
700+
"@com_google_absl//absl/base:core_headers",
701+
"@com_google_absl//absl/container:flat_hash_map",
708702
"@com_google_absl//absl/status",
703+
"@com_google_absl//absl/synchronization",
704+
"@local_tsl//tsl/platform:logging",
709705
"@local_tsl//tsl/platform:statusor",
710706
],
711707
)

0 commit comments

Comments
 (0)