Update player list view along with player list when setting player list for CraftServer

Author: InitAuther97

arclight-common/src/main/java/io/izzel/arclight/common/mixin/bukkit/CraftServerMixin.java

@@ -1,7 +1,8 @@
 package io.izzel.arclight.common.mixin.bukkit;
 
+import com.google.common.collect.Lists;
 import io.izzel.arclight.common.bridge.bukkit.CraftServerBridge;
-import io.izzel.arclight.common.mod.server.ArclightServer;
+import io.izzel.arclight.common.bridge.core.entity.player.ServerPlayerEntityBridge;
 import jline.console.ConsoleReader;
 import net.minecraft.server.dedicated.DedicatedPlayerList;
 import net.minecraft.server.dedicated.DedicatedServer;
@@ -12,6 +13,7 @@
 import org.bukkit.configuration.file.YamlConfiguration;
 import org.bukkit.craftbukkit.v.CraftServer;
 import org.bukkit.craftbukkit.v.command.CraftCommandMap;
+import org.bukkit.craftbukkit.v.entity.CraftPlayer;
 import org.bukkit.craftbukkit.v.help.SimpleHelpMap;
 import org.bukkit.craftbukkit.v.scheduler.CraftScheduler;
 import org.bukkit.event.server.ServerLoadEvent;
@@ -36,10 +38,7 @@
 
 import java.io.File;
 import java.io.IOException;
-import java.util.HashMap;
-import java.util.List;
-import java.util.Locale;
-import java.util.Map;
+import java.util.*;
 import java.util.logging.Level;
 import java.util.logging.Logger;
 
@@ -55,6 +54,7 @@ public abstract class CraftServerMixin implements CraftServerBridge {
     @Shadow @Final protected DedicatedServer console;
     @Shadow @Final @Mutable private String serverName;
     @Shadow @Final @Mutable protected DedicatedPlayerList playerList;
+    @Shadow @Final @Mutable private List<CraftPlayer> playerView;
     @Shadow @Final private Map<String, World> worlds;
     @Shadow public int reloadCount;
     @Shadow private YamlConfiguration configuration;
@@ -101,7 +101,13 @@ public String getVersion() {
 
     @Override
     public void bridge$setPlayerList(PlayerList playerList) {
+        // Though I'm not sure why we need this player list setter
+        // Player list view should be changed along with player list
+        // Or unexpected problem may happen
         this.playerList = (DedicatedPlayerList) playerList;
+        this.playerView = Collections.unmodifiableList(Lists.transform(playerList.players, player ->
+                ((ServerPlayerEntityBridge)player).bridge$getBukkitEntity()
+                ));
     }
 
     /**