Add Origin header to LocalContexts API calls #11643
Open
+13
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Dataverse currently has functionality to make calls the the localcontextshub server to support connects between Dataverse datasets and LC projects (see https://github.com/gdcc/dataverse-external-vocab-support/tree/main/packages/local_contexts). Per LC request (email between @qqmyers and Ashley R at LC), this PR adds the Dataverse instance URL as an Origin header on such requests. The intent is to support LC in restricting the use of specific API keys to specific Dataverse instances.
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this: Coordinate with LC to verify the header is sent when tested against their sandbox.localcontextshub.org server. (The code on their end is still in development and expected in the next few months.)
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: