prevent default dataset type from being deleted #10517

Author: pdurbin

src/main/java/edu/harvard/iq/dataverse/api/Datasets.java

@@ -5178,6 +5178,15 @@ public Response deleteDatasetType(@Context ContainerRequestContext crc, @PathPar
             throw new IllegalArgumentException("ID must be a number");
         }
 
+        DatasetType datasetTypeToDelete = datasetTypeSvc.getById(idToDelete);
+        if (datasetTypeToDelete == null) {
+            return error(BAD_REQUEST, "Could not find dataset type with id " + idToDelete);
+        }
+
+        if (DatasetType.DEFAULT_DATASET_TYPE.equals(datasetTypeToDelete.getName())) {
+            return error(Status.FORBIDDEN, "You cannot delete the default dataset type: " + DatasetType.DEFAULT_DATASET_TYPE);
+        }
+
         try {
             int numDeleted = datasetTypeSvc.deleteById(idToDelete);
             if (numDeleted == 1) {

src/test/java/edu/harvard/iq/dataverse/api/DatasetTypesIT.java

@@ -7,6 +7,7 @@
 import jakarta.json.Json;
 import static jakarta.ws.rs.core.Response.Status.BAD_REQUEST;
 import static jakarta.ws.rs.core.Response.Status.CREATED;
+import static jakarta.ws.rs.core.Response.Status.FORBIDDEN;
 import static jakarta.ws.rs.core.Response.Status.OK;
 import java.util.UUID;
 import org.hamcrest.CoreMatchers;
@@ -182,6 +183,28 @@ public void testGetDefaultDatasetType() {
                 .body("data.name", equalTo(DatasetType.DEFAULT_DATASET_TYPE));
     }
 
+    @Test
+    public void testDeleteDefaultDatasetType() {
+        Response getType = UtilIT.getDatasetType(DatasetType.DEFAULT_DATASET_TYPE);
+        getType.prettyPrint();
+        getType.then().assertThat()
+                .statusCode(OK.getStatusCode())
+                .body("data.name", equalTo(DatasetType.DEFAULT_DATASET_TYPE));
+
+        Long doomed = JsonPath.from(getType.getBody().asString()).getLong("data.id");
+
+        Response createUser = UtilIT.createRandomUser();
+        createUser.then().assertThat().statusCode(OK.getStatusCode());
+        String username = UtilIT.getUsernameFromResponse(createUser);
+        String apiToken = UtilIT.getApiTokenFromResponse(createUser);
+        UtilIT.setSuperuserStatus(username, true).then().assertThat().statusCode(OK.getStatusCode());
+
+        Response deleteType = UtilIT.deleteDatasetTypes(doomed, apiToken);
+        deleteType.prettyPrint();
+        deleteType.then().assertThat()
+                .statusCode(FORBIDDEN.getStatusCode());
+    }
+
     @Test
     public void testAddAndDeleteDatasetType() {
         Response createUser = UtilIT.createRandomUser();