Skip to content

Commit cf5447c

Browse files
committed
Merge branch 'master' of https://github.com/icrar/daliuge into LIU-470
2 parents 52bbcdd + 6073c91 commit cf5447c

File tree

3 files changed

+15
-6
lines changed

3 files changed

+15
-6
lines changed

.github/workflows/run-unit-tests.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ jobs:
8787

8888
finish:
8989
needs: run_tests
90-
runs-on: ubuntu-20.04
90+
runs-on: ubuntu-22.04
9191
steps:
9292
- name: Coveralls Finished
9393
uses: coverallsapp/github-action@master

daliuge-engine/dlg/apps/simple.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -659,7 +659,8 @@ def gather_inputs(self):
659659
# @par EAGLE_START
660660
# @param category PythonApp
661661
# @param tag daliuge
662-
# @param greet World/String/ApplicationArgument/NoPort/ReadWrite//False/False/What appears after 'Hello '
662+
# @param greet World/String/ApplicationArgument/InputPort/ReadWrite//False/False/What appears after 'Hello '
663+
# @param hello "world"/Object/ApplicationArgument/OutputPort/ReadWrite//False/False/message
663664
# @param log_level "NOTSET"/Select/ComponentParameter/NoPort/ReadWrite/NOTSET,DEBUG,INFO,WARNING,ERROR,CRITICAL/False/False/Set the log level for this drop
664665
# @param dropclass dlg.apps.simple.HelloWorldApp/String/ComponentParameter/NoPort/ReadOnly//False/False/Application class
665666
# @param base_name simple/String/ComponentParameter/NoPort/ReadOnly//False/False/Base name of application class

daliuge-engine/dlg/manager/web/static/js/dm.js

+12-4
Original file line numberDiff line numberDiff line change
@@ -580,11 +580,18 @@ function startStatusQuery(serverUrl, sessionId, selectedNode, graph_update_handl
580580
// to know when we go to RUNNING.
581581
// During RUNNING (or potentially FINISHED/CANCELLED, if the execution is
582582
// extremely fast) we need to start updating the status of the graph
583-
if (status == 3 || status == 4 || status == 5) {
583+
if (status === 3 || status === 4 || status === 5) {
584584
startGraphStatusUpdates(serverUrl, sessionId, selectedNode, delay,
585585
status_update_handler);
586586
}
587-
else if (status == 0 || status == 1 || status == 2 || status == -1) {
587+
else if (status === 0 || status === 1 || status === 2 || status === -1) {
588+
if (status === 2) {
589+
// Visualise the drops if we are trying to 'deploy' them.
590+
var keys = Object.keys(doSpecs);
591+
keys.sort();
592+
var statuses = keys.map(function (k) { return {"status": 0} });
593+
status_update_handler(statuses);
594+
}
588595
// schedule a new JSON request
589596
updateGraphDelayTimer = d3.timer(updateGraph, delay);
590597
updateGraphDelayTimerActive = true;
@@ -605,7 +612,9 @@ function startStatusQuery(serverUrl, sessionId, selectedNode, graph_update_handl
605612

606613
function _addNode(g, doSpec, url) {
607614

608-
if (g.hasNode(g)) {
615+
var oid = doSpec.oid;
616+
617+
if (g.hasNode(oid)) {
609618
return false;
610619
}
611620

@@ -628,7 +637,6 @@ function _addNode(g, doSpec, url) {
628637
}
629638
url = url.replace("api/","") + "/graph/drop/" + doSpec.oid;
630639
let link = "<a href=" + url + " target='_blank'>Details</a>";
631-
var oid = doSpec.oid;
632640
var html = '<div class="drop-label ' + typeShape + '" id="id_' + oid + '">';
633641
html += '<span class="notes">' + notes + '</span>';
634642
oid_date = doSpec.oid.split("_")[0];

0 commit comments

Comments
 (0)