Skip to content

Commit c394c83

Browse files
dnwed1egoaz
authored andcommitted
fix: fill in the Fetch{Request,Response} protocol
In order to consume zstd-compressed records the consumer needs to send and receive version 10 FetchRequest/FetchResponses, but they need to do so in a well-formed manner that adheres to the encoding format. Ref: https://kafka.apache.org/protocol Signed-off-by: Dominic Evans <[email protected]>
1 parent eca4c40 commit c394c83

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

fetch_request.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -228,6 +228,7 @@ func (r *FetchRequest) version() int16 {
228228
return r.Version
229229
}
230230

231+
// FIXME: get these correct
231232
func (r *FetchRequest) requiredVersion() KafkaVersion {
232233
switch r.Version {
233234
case 0:

fetch_response.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -324,6 +324,7 @@ func (r *FetchResponse) version() int16 {
324324
return r.Version
325325
}
326326

327+
// FIXME: get these correct
327328
func (r *FetchResponse) requiredVersion() KafkaVersion {
328329
switch r.Version {
329330
case 0:

0 commit comments

Comments
 (0)