Skip to content

Commit 5534ffc

Browse files
authored
Merge pull request #1481 from agapoff/improved-mock-list-acls-response
Improve NewMockListAclsResponse
2 parents 6cdd596 + b03ef8d commit 5534ffc

File tree

1 file changed

+22
-4
lines changed

1 file changed

+22
-4
lines changed

mockresponses.go

Lines changed: 22 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -812,14 +812,32 @@ func NewMockListAclsResponse(t TestReporter) *MockListAclsResponse {
812812
func (mr *MockListAclsResponse) For(reqBody versionedDecoder) encoder {
813813
req := reqBody.(*DescribeAclsRequest)
814814
res := &DescribeAclsResponse{}
815-
816815
res.Err = ErrNoError
817816
acl := &ResourceAcls{}
818-
acl.Resource.ResourceName = *req.ResourceName
817+
if req.ResourceName != nil {
818+
acl.Resource.ResourceName = *req.ResourceName
819+
}
820+
acl.Resource.ResourcePatternType = req.ResourcePatternTypeFilter
819821
acl.Resource.ResourceType = req.ResourceType
820-
acl.Acls = append(acl.Acls, &Acl{})
821-
res.ResourceAcls = append(res.ResourceAcls, acl)
822822

823+
host := "*"
824+
if req.Host != nil {
825+
host = *req.Host
826+
}
827+
828+
principal := "User:test"
829+
if req.Principal != nil {
830+
principal = *req.Principal
831+
}
832+
833+
permissionType := req.PermissionType
834+
if permissionType == AclPermissionAny {
835+
permissionType = AclPermissionAllow
836+
}
837+
838+
acl.Acls = append(acl.Acls, &Acl{Operation: req.Operation, PermissionType: permissionType, Host: host, Principal: principal})
839+
res.ResourceAcls = append(res.ResourceAcls, acl)
840+
res.Version = int16(req.Version)
823841
return res
824842
}
825843

0 commit comments

Comments
 (0)