switch to MaxResponseSize

Signed-off-by: Ryan Belgrave <[email protected]>

Author: rmb938

packet_decoder.go

@@ -15,7 +15,6 @@ type packetDecoder interface {
 	getUVarint() (uint64, error)
 	getFloat64() (float64, error)
 	getArrayLength() (int, error)
-	getArrayLengthNoLimit() (int, error)
 	getCompactArrayLength() (int, error)
 	getBool() (bool, error)
 	getEmptyTaggedFieldArray() (int, error)

real_decoder.go

@@ -115,26 +115,12 @@ func (rd *realDecoder) getArrayLength() (int, error) {
 	if tmp > rd.remaining() {
 		rd.off = len(rd.raw)
 		return -1, ErrInsufficientData
-	} else if tmp > 2*math.MaxUint16 {
+	} else if tmp > int(MaxResponseSize) {
 		return -1, errInvalidArrayLength
 	}
 	return tmp, nil
 }
 
-func (rd *realDecoder) getArrayLengthNoLimit() (int, error) {
-	if rd.remaining() < 4 {
-		rd.off = len(rd.raw)
-		return -1, ErrInsufficientData
-	}
-	tmp := int(int32(binary.BigEndian.Uint32(rd.raw[rd.off:])))
-	rd.off += 4
-	if tmp > rd.remaining() {
-		rd.off = len(rd.raw)
-		return -1, ErrInsufficientData
-	}
-	return tmp, nil
-}
-
 func (rd *realDecoder) getCompactArrayLength() (int, error) {
 	n, err := rd.getUVarint()
 	if err != nil {

record_batch.go

@@ -157,11 +157,7 @@ func (b *RecordBatch) decode(pd packetDecoder) (err error) {
 		return err
 	}
 
-	// Using NoLimit because a single record batch could contain
-	// more then 2*math.MaxUint16 records. The packet decoder will
-	// check to make sure the array is not greater than the
-	// remaining bytes.
-	numRecs, err := pd.getArrayLengthNoLimit()
+	numRecs, err := pd.getArrayLength()
 	if err != nil {
 		return err
 	}