Skip to content

Change detection conditions not refreshing as you are clicking around #2314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jhutar opened this issue Mar 21, 2025 · 1 comment
Open
Labels
area/UI priority/medium Medium priority type/bug Something isn't working

Comments

@jhutar
Copy link
Contributor

jhutar commented Mar 21, 2025

Describe the bug

Change detection conditions not refreshing as you are clicking around. I think this is only a case for "Fixed Threshold" conditions.

Screen recording: https://drive.google.com/file/d/1CaKxVivVoaLjQssRNghB3hEVe7yyGGkA/view

To Reproduce

  1. Go to test page, e.g. https://horreum.corp.redhat.com/test/254
  2. Switch to "Change detection" tab
  3. Add 2 metrics with different "Fixed Threshold" conditions, e.g. see ".results.measurements.KPI.errors" and ".results.measurements.KPI.mean" in above linked test
  4. Notice how the form does not update as you are switching between metrics or even when you go to metric that does not have any condition at all

Version

Whatever is on Prod as of now.

Browser

firefox-136.0.1-1.fc41.x86_64

@jhutar jhutar added the type/bug Something isn't working label Mar 21, 2025
@lampajr
Copy link
Member

lampajr commented Mar 21, 2025

Thanks again @jhutar especially for the recording, really heplful🙏🏻

I noticed the same behavior yesterday while investigating the changes detection and I can confirmt what you are saying. It looks like the internal tabs (with the different change detection alg) for each Variable is not switched when changing the selected Variable on the left.

@lampajr lampajr added area/UI priority/medium Medium priority labels Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/UI priority/medium Medium priority type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants