simplify code (the parameter was something used during the IE times)

Author: rbri

src/main/java/org/htmlunit/WebClient.java

@@ -2602,13 +2602,12 @@ public boolean isOutdated() {
      * @param target the name of the target window
      * @param request the request to perform
      * @param checkHash if true check for hashChenage
-     * @param forceLoad if true always load the request even if there is already the same in the queue
      * @param forceAttachmentWithFilename if not {@code null} the AttachmentHandler isAttachment() method is not called,
      *        the response has to be handled as attachment in any case
      * @param description information about the origin of the request. Useful for debugging.
      */
     public void download(final WebWindow requestingWindow, final String target,
-        final WebRequest request, final boolean checkHash, final boolean forceLoad,
+        final WebRequest request, final boolean checkHash,
         final String forceAttachmentWithFilename, final String description) {
 
         final WebWindow targetWindow = resolveWindow(requestingWindow, target);
@@ -2645,9 +2644,7 @@ public void download(final WebWindow requestingWindow, final String target,
                 final WebRequest otherRequest = otherLoadJob.request_;
                 final URL otherUrl = otherRequest.getUrl();
 
-                // TODO: investigate but it seems that IE considers query string too but not FF
-                if (!forceLoad
-                    && url.getPath().equals(otherUrl.getPath()) // fail fast
+                if (url.getPath().equals(otherUrl.getPath()) // fail fast
                     && url.toString().equals(otherUrl.toString())
                     && request.getRequestParameters().equals(otherRequest.getRequestParameters())
                     && Objects.equals(request.getRequestBody(), otherRequest.getRequestBody())) {

src/main/java/org/htmlunit/html/HtmlAnchor.java

@@ -195,7 +195,7 @@ protected void doClickStateUpdate(final boolean shiftKey, final boolean ctrlKey,
             target = page.getResolvedTarget(getTargetAttribute());
         }
         page.getWebClient().download(page.getEnclosingWindow(), target, webRequest,
-                true, false, (ATTRIBUTE_NOT_DEFINED != downloadAttribute) ? downloadAttribute : null, "Link click");
+                true, (ATTRIBUTE_NOT_DEFINED != downloadAttribute) ? downloadAttribute : null, "Link click");
     }
 
     private boolean relContainsNoreferrer() {

src/main/java/org/htmlunit/html/HtmlForm.java

@@ -191,7 +191,7 @@ && getAttributeDirect(ATTRIBUTE_NOVALIDATE) != ATTRIBUTE_NOT_DEFINED) {
 
         final WebWindow webWindow = htmlPage.getEnclosingWindow();
         // Calling form.submit() twice forces double download.
-        webClient.download(webWindow, target, request, false, false, null, "JS form.submit()");
+        webClient.download(webWindow, target, request, false, null, "JS form.submit()");
     }
 
     /**

src/main/java/org/htmlunit/javascript/host/Location.java

@@ -229,7 +229,7 @@ public void reload(final boolean force) throws IOException {
             request.setRefererHeader(htmlPage.getUrl());
         }
 
-        webWindow.getWebClient().download(webWindow, "", request, false, false, null, "JS location.reload");
+        webWindow.getWebClient().download(webWindow, "", request, false, null, "JS location.reload");
     }
 
     /**
@@ -315,7 +315,7 @@ public void setHref(final String newLocation) throws IOException {
             request.setRefererHeader(page.getUrl());
 
             webWindow = window_.getWebWindow();
-            webWindow.getWebClient().download(webWindow, "", request, true, false, null, "JS set location");
+            webWindow.getWebClient().download(webWindow, "", request, true, null, "JS set location");
         }
         catch (final MalformedURLException e) {
             if (LOG.isErrorEnabled()) {