fix: app icon double-encode bug

When getting a stream for an SVG icon from AppIconService with a
previously-fetched stored icon provided, a double-encoding bug was
preventing a valid image from being obtained.

Author: KernelDeimos

src/backend/src/modules/apps/AppIconService.js

@@ -98,15 +98,15 @@ class AppIconService extends BaseService {
     async get_icon_stream ({ app_icon, app_uid, size, tries = 0 }) {
         // If there is an icon provided, and it's an SVG, we'll just return it
         if ( app_icon ) {
-            const metadata = app_icon.split(',')[0];
+            const [metadata, data] = app_icon.split(',');
             const input_mime = metadata.split(';')[0].split(':')[1];
 
             // svg icons will be sent as-is
             if (input_mime === 'image/svg+xml') {
                 return {
                     mime: 'image/svg+xml',
                     get stream () {
-                        return buffer_to_stream(Buffer.from(app_icon));
+                        return buffer_to_stream(Buffer.from(data, 'base64'));
                     },
                     data_url: app_icon,
                 }