Skip to content

Warning for "not enough disk space" does not appear on macOS #967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
StupidRepo opened this issue Feb 8, 2022 · 6 comments · Fixed by #1203 or #1336
Closed

Warning for "not enough disk space" does not appear on macOS #967

StupidRepo opened this issue Feb 8, 2022 · 6 comments · Fixed by #1203 or #1336

Comments

@StupidRepo
Copy link

StupidRepo commented Feb 8, 2022

IMPORTANT! Do not erase this template!

Is this a game issue? If YES please use our Discord to get help.

Open here only issues with Heroic like: Heroic doesn't open, some button is out of place, Heroic closes unexpectedly, installs got interrupted, etc.

Try to get help on our Wiki first: https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/wiki/Troubleshooting

Describe the bug
So, what happens is that I'm on a Mac, trying to download Hitman™ but it seems that it can't get the Download Size and/or Install Size meaning that when I press Download, it stalls for like 3s (saying "Installing 0%...") then it says the download was complete, when it wasn't.

I think it's because since it can't calculate Download Size or Install Size, it thinks the game has been downloaded. It only happens on Hitman™ therefor making the game uninstallable

To Reproduce
Steps to reproduce the behavior:

  1. Log into an account that has Hitman™ on it.
  2. Go to the Library
  3. Click on HITMAN
  4. Click Install
  5. Wait for like 5s
  6. Witness bug

Expected behavior
Game is supposed to install.

Screenshots
Screenshot 2022-02-08 at 7 48 06 PM

Desktop (please complete the following information):

  • OS: macOS 11
  • Heroic Version: 2.1.1
  • Game: Hitman™
  • Wine/Proton version: CrossOver
  • Hardware specs (RAM, CPU, GPU): M1

Additional context
Add any other context about the problem here.

@StupidRepo StupidRepo changed the title Hitman™️ doesn't install Hitman™ doesn't install Feb 8, 2022
@StupidRepo
Copy link
Author

Solved: It seems I didn't have any disk space

@CommandMC CommandMC changed the title Hitman™ doesn't install Warning for "not enough disk space" does not appear on macOS Feb 10, 2022
@CommandMC
Copy link
Collaborator

if (stdout.includes(noSpaceMsg)) {

this check should find the error and display a message box. It seems like it's not working on macOS for some reason

@StupidRepo
Copy link
Author

Hm, ok.

@flavioislima
Copy link
Member

I believe this might be affecting other systems as well so let's investigate

@flavioislima
Copy link
Member

Can you guys try the version here after the build finishes?
https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/actions/runs/2157692390

@flavioislima
Copy link
Member

It seems this isnt fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants