Skip to content

Cannot open a store page after logging in. #3569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Giger22 opened this issue Feb 14, 2024 · 9 comments · Fixed by #3575
Closed

Cannot open a store page after logging in. #3569

Giger22 opened this issue Feb 14, 2024 · 9 comments · Fixed by #3575
Labels
bug:unconfirmed Someone works on identifying the issue

Comments

@Giger22
Copy link

Giger22 commented Feb 14, 2024

Describe the bug

After I logged in to GOG I cannot refresh and I cannot see its store page.

Add logs

No logs.

Steps to reproduce

  1. Logint to GOG.
  2. Click on Stores->GOG Store
  3. Blank screen

Expected behavior

Normal store page.

Screenshots

Screenshot

Heroic Version

Latest Stable

System Information

  • OS [e. g. "Ubuntu"]: Artix Linux OpenRC

Additional information

No response

@Giger22 Giger22 added the bug:unconfirmed Someone works on identifying the issue label Feb 14, 2024
@Giger22
Copy link
Author

Giger22 commented Feb 14, 2024

Amazon

@imLinguin
Copy link
Member

Heroic redirects the store page through our partner link starting 2.13.0. As it's handled by adtraction this is what happens when the adtraction domain is blocked. We'll provide a option to disable partner links in the future

@Giger22
Copy link
Author

Giger22 commented Feb 14, 2024

Yeah, you are right. I just checked and Portmaster blocked track.adtraction.com when attempting to connect.

@Giger22 Giger22 changed the title Can open a store page after logging in. Cannot open a store page after logging in. Feb 14, 2024
@imLinguin imLinguin linked a pull request Feb 15, 2024 that will close this issue
4 tasks
@theriverlethe
Copy link

theriverlethe commented Feb 17, 2024

This is more likely what was going on in my case than a problem with PowerShell. Can you explain the reason for going through adtraction?

@imLinguin
Copy link
Member

The partner link we got from GOG works that way. This is their way to detect what purchases were made after being redirected through such link.

@8BitCerberus
Copy link

Ahhh! I've been wondering why all of the sudden GOG hasn't been working. I guess it's been my Pi-hole. Do you get any benefit from the partner link, or is it only for GOG's tracking/metrics? If you are getting any percentage of sales made with the partner link I'd be happy to whitelist adtraction, but if not I'll keep it blocked and wait for the fallback workaround.

@arielj
Copy link
Collaborator

arielj commented Feb 26, 2024

Ahhh! I've been wondering why all of the sudden GOG hasn't been working. I guess it's been my Pi-hole. Do you get any benefit from the partner link, or is it only for GOG's tracking/metrics? If you are getting any percentage of sales made with the partner link I'd be happy to whitelist adtraction, but if not I'll keep it blocked and wait for the fallback workaround.

we get a % of the games purchased if that link is followed

@bnthn
Copy link

bnthn commented Apr 26, 2024

It could be beneficial to provide the specific partner link e.g. inside the readme so people can add an exception to their adblockers

@imLinguin
Copy link
Member

I think the modal that is shown when adtraction fails to load is clear enough about the domain.
obraz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:unconfirmed Someone works on identifying the issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants