Skip to content

Heroic launcher crash at startup. #3272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Aspromayros opened this issue Nov 28, 2023 · 4 comments · Fixed by #3373
Closed

Heroic launcher crash at startup. #3272

Aspromayros opened this issue Nov 28, 2023 · 4 comments · Fixed by #3373
Labels
bug:unconfirmed Someone works on identifying the issue GOG

Comments

@Aspromayros
Copy link

Describe the bug

When I open the launcher it crashes after 2-3 seconds. (Flatpak)

Add logs

which: no wine in (/app/bin:/app/bin:/app/utils/bin:/usr/bin:/usr/lib/extensions/vulkan/MangoHud/bin:/usr/lib/extensions/vulkan/gamescope/bin:/usr/lib/extensions/vulkan/OBSVkCapture/bin:/app/bin/heroic/resources/app.asar.unpacked/build/bin/linux)
(08:56:06) INFO:    [Winetricks]:       Downloading Winetricks
(node:13) UnhandledPromiseRejectionWarning: TypeError: Cannot read properties of undefined (reading 'url_format')
    at gogToUnifiedInfo (/app/bin/heroic/resources/app.asar/build/electron/main.9bb8a6b7.js:3:10588)
    at /app/bin/heroic/resources/app.asar/build/electron/main.9bb8a6b7.js:3:4357
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
(Use `heroic --trace-warnings ...` to show where the warning was created)
(node:13) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 6)
(node:13) PromiseRejectionHandledWarning: Promise rejection was handled asynchronously (rejection id: 6)
(08:56:06) INFO:    [Gog]:              Saved games data
(08:56:06) WARNING: [Backend]:          listUpdateableGames not implemented on Sideload Library Manager
(08:56:06) INFO:    [Gog]:              Found 0 game(s) to update
(08:56:06) INFO:    [Legendary]:        Checking for game updates: LEGENDARY_CONFIG_PATH=/home/nikitas/.var/app/com.heroicgameslauncher.hgl/config/heroic/legendaryConfig/legendary /app/bin/heroic/resources/app.asar.unpacked/build/bin/linux/legendary list --third-party

Steps to reproduce

  1. Open the flatpak version of heroic launcher.

Expected behavior

To stay open and without crash.

Screenshots

Screencast_20231128_085301-1.mp4

Heroic Version

Latest Stable (Flatpak)

System Information

  • OS openSUSE Tumbleweed
  • DE KDE Plasma
  • CPU 3600x
  • GPU 6700xt

Additional information

No response

@Aspromayros Aspromayros added the bug:unconfirmed Someone works on identifying the issue label Nov 28, 2023
@Nocccer Nocccer added the GOG label Nov 28, 2023
@flavioislima
Copy link
Member

it seems to be that you have some item on your library that Heroic doesn't know how to handle. Maybe @imLinguin might have a better opinion on that.

@imLinguin
Copy link
Member

Some game might be missing image data, like background etc...
I just pushed the change to #3020 that should address it

@flavioislima
Copy link
Member

Some game might be missing image data, like background etc... I just pushed the change to #3020 that should address it

url_format?
TypeError: Cannot read properties of undefined (reading 'url_format')

@imLinguin
Copy link
Member

Yes, we were not checking if vertical_image or the background is undefined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:unconfirmed Someone works on identifying the issue GOG
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants