Skip to content

Running a game from a desktop shortcut or from steam shouldn't start downloads #3155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arielj opened this issue Oct 24, 2023 · 1 comment · Fixed by #3161
Closed

Running a game from a desktop shortcut or from steam shouldn't start downloads #3155

arielj opened this issue Oct 24, 2023 · 1 comment · Fixed by #3161
Labels
bug:confirmed Something isn't working.

Comments

@arielj
Copy link
Collaborator

arielj commented Oct 24, 2023

Describe the bug

I have things on the download queue and stopped everything. I closed Heroic and then I launched a game from a desktop shortcut.

After closing the game, Heroic was still running so I opened it. A download was in progress.

Apart form the problem that the download is happening in the background and I don't know that, this creates a problem on the steam deck in gaming mode: when closing a game, steam can't close heroic cause there's a download in progress, so we end up in a black screen and we have to press B to abort the game.

Add logs

Nothing relevant.

Steps to reproduce

  1. Add some game to the queue
  2. Pause the download
  3. Close Heroic
  4. Launch a game from a shortcut (desktop or steam)
  5. Close the game

In desktop mode you can open the Heroic UI to see the game is being downloaded. In gaming mode the game won't fully close and needs to be aborted.

Expected behavior

When launching a game from any shortcut, heroic should NOT start downloads.

Screenshots

No response

Heroic Version

Latest Stable

System Information

Not relevant

Additional information

This can probably be solved by waiting some time to start the downloads when start heroic to have time to process if the start is triggered by the protocol, and only start downloads if not started by the protocol.

@arielj arielj added bug:unconfirmed Someone works on identifying the issue bug:confirmed Something isn't working. and removed bug:unconfirmed Someone works on identifying the issue labels Oct 24, 2023
@flavioislima
Copy link
Member

Makes sense, adding a check if it is using no-gui here should solve this issue:

I can open a quick PR to fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:confirmed Something isn't working.
Projects
None yet
3 participants
@arielj @flavioislima and others