Skip to content

Missing " breaks launching from Steam with portable version of Heroic #3125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HazardousBackup opened this issue Oct 9, 2023 · 0 comments · Fixed by #3131
Closed

Missing " breaks launching from Steam with portable version of Heroic #3125

HazardousBackup opened this issue Oct 9, 2023 · 0 comments · Fixed by #3131
Labels
bug:confirmed Something isn't working.

Comments

@HazardousBackup
Copy link
Contributor

Describe the bug

It appears there is a missing " on games added to Steam when using the portable version of Heroic Launcher.

This breaks attempts to launch the game via Steam.

Add logs

< no relevant logs available >

Steps to reproduce

  1. Use portable version of Heroic
  2. Select any game
  3. Add to Steam
  4. Restart Steam
  5. Attempt Launch
  6. Heroic UI appears
  7. Game fails to ever start

Expected behavior

Heroic launches game from background.

Screenshots

No response

Heroic Version

Latest Stable

System Information

  • OS [e. g. "Ubuntu"]: Windows

Additional information

https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/blob/1020e7e2d6fb5379613f8d96b3d61036c7cb0d00/src/backend/shortcuts/nonesteamgame/nonesteamgame.ts#L263C64-L263C64

This appears to be the line with the issue. I'd have put in a pull request but I felt that would be inappropriate without setting up an env and building to confirm.

Small mention but #3124 exacerbates the issue since any entries manually fixed will then have a chance of no longer being seen by Heroic and so be left behind on uninstall.

@HazardousBackup HazardousBackup added the bug:unconfirmed Someone works on identifying the issue label Oct 9, 2023
@arielj arielj added bug:confirmed Something isn't working. and removed bug:unconfirmed Someone works on identifying the issue labels Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:confirmed Something isn't working.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants