Skip to content

Search suggestions/autocomplete shows DLCs but then picking them shows no results #2575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arielj opened this issue Mar 26, 2023 · 4 comments
Assignees
Labels
good first issue Good for newcomers.

Comments

@arielj
Copy link
Collaborator

arielj commented Mar 26, 2023

Describe the bug

When using the search, a dropdown with suggestions/autocomplete appears. The results include DLCs. When selecting a DLC, since DLCs are not actually displayed in the library, the library shows no results.

image

image

Add logs

Nothing relevant

Steps to reproduce

  1. Search for something that could be part of a DLC name
  2. Select the DLC in the suggestions

Expected behavior

DLCs should not show up as suggestions.

Screenshots

No response

Heroic Version

Latest Stable

System Information

Not relevant

Additional information

No response

@arielj arielj added the good first issue Good for newcomers. label Mar 26, 2023
@amanx123
Copy link

Would like to work on this. Assign me please

@arielj
Copy link
Collaborator Author

arielj commented Jun 2, 2023

hey @amanx123, any update on this? if you can't work on this I can unassign you in case somebody else wants to take this

@arielj
Copy link
Collaborator Author

arielj commented Jun 3, 2023

@amanx123 I included a fix for this in a PR with other fixes too, so no need to work on it anymore

@arielj
Copy link
Collaborator Author

arielj commented Jul 29, 2023

This got fixed in 2.9.1, DLCs don't show up as suggestions

@arielj arielj closed this as completed Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers.
Projects
None yet
Development

No branches or pull requests

2 participants