Classic themes have invisible links #2552

Zorrototo · 2023-03-18T10:25:54Z

Describe the bug

Link with Classic skins are invisible. For example, default skin has colored links in the Alternative Login method popup, but with Zombie Classic for example, I would expect the links to be green color but they are white like the normal text so we don't see them.

Add logs

(11:18:57) INFO:    [Connection]:       Connectivity: check-online
(11:18:57) INFO:    [Connection]:       Pinging external endpoints
(11:18:57) INFO:    [Legendary]:        Running command: /opt/Heroic/resources/app.asar.unpacked/build/bin/linux/legendary --version
(11:18:57) INFO:    [Legendary]:        Legendary location: /opt/Heroic/resources/app.asar.unpacked/build/bin/linux/legendary
(11:18:57) INFO:    [Gog]:              GOGDL location: /opt/Heroic/resources/app.asar.unpacked/build/bin/linux/gogdl
(11:18:57) INFO:    [Gog]:              GOGDL location: /opt/Heroic/resources/app.asar.unpacked/build/bin/linux/gogdl
(11:18:57) WARNING: [Backend]:          Protocol already registered.
(11:18:57) INFO:    [Gog]:              Running command: /opt/Heroic/resources/app.asar.unpacked/build/bin/linux/gogdl --version
(11:18:57) INFO:    [Connection]:       Connectivity: online
(11:18:58) INFO:    [Backend]:          Loading Screen Ready
(11:18:58) INFO:    [Frontend]:         Refreshing Library
(11:18:58) INFO:    [Legendary]:        Refreshing library...
(11:18:58) INFO:    [Legendary]:        Refreshing Epic Games...
(11:18:58) INFO:    [Legendary]:        Game list updated, got 274 games & DLCs
(11:18:58) INFO:    [Backend]:          Frontend Ready
(11:18:58) INFO:    [Backend]:          AreWeAntiCheatYet data downloaded
(11:18:58) INFO:    [Backend]:          Checking for new Heroic Updates
(11:18:58) INFO:    [Backend]:          Checking for current version changelog
(11:18:58) INFO:    [Backend]:          

Heroic Version: 2.6.2 Trafalgar Law
Legendary Version:  0.20.32 Dark Energy (hotfix #6)
GOGdl Version: 0.6

Electron Version: 22.2.0
Chrome Version: 108.0.5359.215
NodeJS Version: 16.17.1

OS: ManjaroLinux KERNEL: 6.1.19-1-MANJARO ARCH: x64
CPU: AMD Ryzen 5 3600 6-Core Processor @3.6 GOVERNOR: schedutil
RAM: Total: 15.55 GiB Available: 1.33 GiB
GRAPHICS: GPU0: NVIDIA GeForce GTX 1060 6GB VRAM: 6070MB DRIVER: 525.89.02 
PROTOCOL: x11

(11:18:58) INFO:    [Legendary]:        Running command: /opt/Heroic/resources/app.asar.unpacked/build/bin/linux/legendary list --third-party
(11:18:58) INFO:    [Legendary]:        Checking for game updates: /opt/Heroic/resources/app.asar.unpacked/build/bin/linux/legendary list --third-party
(11:19:00) INFO:    [Winetricks]:       Downloading Winetricks
(11:19:00) INFO:    [Legendary]:        Found 0 games to update
(11:19:00) INFO:    [Gog]:              Found 0 game(s) to update
(11:19:03) INFO:    [Backend]:          Starting the Download Queue
(11:19:12) INFO:    [Backend]:          Launching The Talos Principle (Bustard)
(11:19:12) INFO:    [Backend]:          Preventing display from sleep
(11:19:12) INFO:    [Backend]:          Checking if wine version exists: Proton - Proton-GE-Proton7-49
(11:19:22) INFO:    [Backend]:          Checking if wine version exists: Proton - Proton-GE-Proton7-49
(11:19:22) WARNING: [Backend]:          You are using Proton, this can lead to some bugs. Please do not open issues with bugs related to games
(11:19:22) INFO:    [Backend]:          Checking if wine version exists: Proton - Proton-GE-Proton7-49
(11:19:22) INFO:    [Backend]:          Checking if wine version exists: Proton - Proton-GE-Proton7-49
(11:19:22) DEBUG:   [Backend]:          Running Wine command: run wineboot --init
(11:19:26) INFO:    [Backend]:          Created/Updated Wineprefix at /home/omano/Games/Heroic/Prefixes/TheTalosPrinciple
(11:19:26) INFO:    [Legendary]:        Running command: /opt/Heroic/resources/app.asar.unpacked/build/bin/linux/legendary launch Bustard --json --offline
(11:19:26) INFO:    [Legendary]:        Launching The Talos Principle: LD_PRELOAD= STEAM_COMPAT_CLIENT_INSTALL_PATH=/home/omano/.steam/steam STEAM_COMPAT_DATA_PATH=/home/omano/Games/Heroic/Prefixes/TheTalosPrinciple PROTON_NO_ESYNC=1 PROTON_NO_FSYNC=1 STEAM_COMPAT_APP_ID=0 SteamAppId=0 SteamGameId=heroic-TheTalosPrinciple PROTON_LOG_DIR=/home/omano /usr/bin/gamemoderun /opt/Heroic/resources/app.asar.unpacked/build/bin/linux/legendary launch Bustard --language en --no-wine --wrapper "'/home/omano/.config/heroic/tools/proton/Proton-GE-Proton7-49/proton' run"
(11:19:27) INFO:    [Backend]:          Stopping Display Power Saver Blocker
(11:19:27) INFO:    [Frontend]:         Refreshing Library
(11:19:27) INFO:    [Legendary]:        Refreshing library...
(11:19:34) INFO:    [Legendary]:        Logging out: /opt/Heroic/resources/app.asar.unpacked/build/bin/linux/legendary auth --delete
(11:19:34) INFO:    [Legendary]:        Running command: /opt/Heroic/resources/app.asar.unpacked/build/bin/linux/legendary cleanup
(11:19:34) INFO:    [Backend]:          Checking for new Heroic Updates
(11:19:34) INFO:    [Backend]:          Checking for current version changelog
(11:19:51) INFO:    [Legendary]:        Logging in: /opt/Heroic/resources/app.asar.unpacked/build/bin/linux/legendary auth --code <redacted>
(11:19:52) INFO:    [Frontend]:         Refreshing Library
(11:19:52) INFO:    [Legendary]:        Refreshing library...
(11:19:52) INFO:    [Legendary]:        Refreshing Epic Games...
(11:19:52) ERROR:   [Legendary]:        Failed to parse MtMassive.json
(11:19:52) ERROR:   [Legendary]:        Failed to parse bobcat.json
(11:19:52) INFO:    [Legendary]:        Game list updated, got 274 games & DLCs
(11:19:52) INFO:    [Frontend]:         Called Login
(11:19:52) INFO:    [Frontend]:         No cache found, getting data from legendary...
(11:19:52) INFO:    [Legendary]:        Refreshing library...
(11:19:52) ERROR:   [Legendary]:        Failed to parse MtMassive.json
(11:19:52) ERROR:   [Legendary]:        Failed to parse bobcat.json
(11:19:52) INFO:    [Legendary]:        Game list updated, got 274 games & DLCs
(11:19:52) INFO:    [Frontend]:         Force Update
(11:19:52) INFO:    [Legendary]:        Running command: /opt/Heroic/resources/app.asar.unpacked/build/bin/linux/legendary list --third-party
(11:19:54) INFO:    [Frontend]:         Refreshing Library
(11:19:54) INFO:    [Legendary]:        Refreshing library...
(11:19:54) INFO:    [Legendary]:        Refreshing Epic Games...
(11:19:54) ERROR:   [Legendary]:        Failed to parse MtMassive.json
(11:19:54) ERROR:   [Legendary]:        Failed to parse bobcat.json
(11:19:54) INFO:    [Legendary]:        Game list updated, got 274 games & DLCs
(11:19:55) INFO:    [Legendary]:        Running command: /opt/Heroic/resources/app.asar.unpacked/build/bin/linux/legendary list --third-party
(11:19:57) INFO:    [Backend]:          Launching The Talos Principle (Bustard)
(11:19:57) INFO:    [Backend]:          Preventing display from sleep
(11:19:57) INFO:    [Backend]:          Checking if wine version exists: Proton - Proton-GE-Proton7-49
(11:19:58) INFO:    [Backend]:          Checking if wine version exists: Proton - Proton-GE-Proton7-49
(11:19:58) WARNING: [Backend]:          You are using Proton, this can lead to some bugs. Please do not open issues with bugs related to games
(11:19:58) INFO:    [Backend]:          Checking if wine version exists: Proton - Proton-GE-Proton7-49
(11:19:58) INFO:    [Backend]:          Checking if wine version exists: Proton - Proton-GE-Proton7-49
(11:19:58) DEBUG:   [Backend]:          Running Wine command: run wineboot --init
(11:20:00) INFO:    [Legendary]:        Running command: /opt/Heroic/resources/app.asar.unpacked/build/bin/linux/legendary launch Bustard --json --offline
(11:20:00) INFO:    [Legendary]:        Launching The Talos Principle: LD_PRELOAD= STEAM_COMPAT_CLIENT_INSTALL_PATH=/home/omano/.steam/steam STEAM_COMPAT_DATA_PATH=/home/omano/Games/Heroic/Prefixes/TheTalosPrinciple PROTON_NO_ESYNC=1 PROTON_NO_FSYNC=1 STEAM_COMPAT_APP_ID=0 SteamAppId=0 SteamGameId=heroic-TheTalosPrinciple PROTON_LOG_DIR=/home/omano /usr/bin/gamemoderun /opt/Heroic/resources/app.asar.unpacked/build/bin/linux/legendary launch Bustard --language en --no-wine --wrapper "'/home/omano/.config/heroic/tools/proton/Proton-GE-Proton7-49/proton' run"
(11:25:36) INFO:    [Frontend]:         Refreshing Library
(11:25:36) INFO:    [Legendary]:        Refreshing library...
(11:25:36) INFO:    [Legendary]:        Refreshing Epic Games...
(11:25:36) INFO:    [Legendary]:        Game list updated, got 274 games & DLCs
(11:25:36) INFO:    [Legendary]:        Running command: /opt/Heroic/resources/app.asar.unpacked/build/bin/linux/legendary list --third-party

Steps to reproduce

Select Zombie Classic theme or other Classic one
Go to Manage Accounts
Click on Alternative Login method
See the link blends in with the text, it is not colored has it probably should

Expected behavior

Links are highlighted with the theme dominant color

Screenshots

No response

Heroic Version

Latest Stable

System Information

OS : Manjaro KDE

Additional information

No response

The text was updated successfully, but these errors were encountered:

Zorrototo · 2023-03-21T22:39:24Z

Default:

Zombie Classic:

We can also see there is no dimming of the background when the popup appears.

Zorrototo · 2023-04-04T19:43:21Z

2.7.0 didn't fix both issues (link color, and the background dimming effect).

apokolokynthosis · 2023-05-10T19:43:11Z

@arielj @flavioislima

I'd like to try my best fixing this problem. In which files should I look for that kind of UI and themes issues ?

arielj · 2023-05-11T02:19:26Z

@Periyte themes are here https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/blob/main/src/frontend/themes.scss and that modal is this component https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/blob/main/src/frontend/screens/Login/components/SIDLogin/index.tsx

apokolokynthosis · 2023-05-11T11:26:14Z

Thanks @arielj ! Should I create a new branch for the pull request or can I use the ui/fix_some_elemts branch ?

arielj · 2023-05-11T12:23:38Z

please create a new branch

Zorrototo · 2023-09-17T00:55:19Z

Any progress on this issue with themes?

arielj added the good first issue Good for newcomers. label Mar 26, 2023

arielj mentioned this issue Sep 17, 2023

[Fix] Some themes fixes #3054

Merged

4 tasks

flavioislima closed this as completed in #3054 Sep 26, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Classic themes have invisible links #2552

Classic themes have invisible links #2552

Zorrototo commented Mar 18, 2023

Zorrototo commented Mar 21, 2023

Zorrototo commented Apr 4, 2023

apokolokynthosis commented May 10, 2023 •

edited

Loading

arielj commented May 11, 2023

apokolokynthosis commented May 11, 2023

arielj commented May 11, 2023

Zorrototo commented Sep 17, 2023

Classic themes have invisible links #2552

Classic themes have invisible links #2552

Comments

Zorrototo commented Mar 18, 2023

Describe the bug

Add logs

Steps to reproduce

Expected behavior

Screenshots

Heroic Version

System Information

Additional information

Zorrototo commented Mar 21, 2023

Zorrototo commented Apr 4, 2023

apokolokynthosis commented May 10, 2023 • edited Loading

arielj commented May 11, 2023

apokolokynthosis commented May 11, 2023

arielj commented May 11, 2023

Zorrototo commented Sep 17, 2023

apokolokynthosis commented May 10, 2023 •

edited

Loading