Skip to content

Uninstall dialog adds an empty space in grid #1930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
arielj opened this issue Oct 22, 2022 · 0 comments · Fixed by #1933
Closed

Uninstall dialog adds an empty space in grid #1930

arielj opened this issue Oct 22, 2022 · 0 comments · Fixed by #1933
Assignees
@arielj

Comments

@arielj
Copy link
Collaborator

arielj commented Oct 22, 2022

Describe the bug

With the new HTML dialogs, when uninstalling a game, a dialog to confirm the uninstall appears and it leaves an empty space in the grid:
image

Add logs

Nothing relevant

Steps to reproduce

  1. Use beta branch
  2. Make sure Grid view is selected
  3. Right click > Uninstall on a game card

Expected behavior

Dialogs should be added somewhere that doesn't affect the layout

Screenshots

No response

System Information

  • Heroic Version [e. g. 2.1.1]: beta branch

Additional information

No response
@arielj arielj self-assigned this Oct 22, 2022
@arielj arielj mentioned this issue Oct 22, 2022
Merged
4 tasks
@arielj arielj linked a pull request Oct 22, 2022 that will close this issue
Some dialog fixes #1933
Merged
4 tasks
@arielj arielj closed this as completed Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arielj arielj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Some dialog fixes Heroic-Games-Launcher/HeroicGamesLauncher
1 participant
@arielj