Skip to content

Context menu focuses 2 items when using a controller #1908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arielj opened this issue Oct 15, 2022 · 0 comments
Closed

Context menu focuses 2 items when using a controller #1908

arielj opened this issue Oct 15, 2022 · 0 comments
Labels
good first issue Good for newcomers.

Comments

@arielj
Copy link
Collaborator

arielj commented Oct 15, 2022

Describe the bug

When using a controller to navigate Heroic, the context menu of a game card highlights the first item with a bright color (the mouse hover color) and the actual focused element by the controller with a dim color, making it hard to see and confusing:

image
Play Now is not the one focused
Uninstall is the one focused

Moving the mouse removes the hover color, even though the mouse is not hovering that item anyway.

Add logs

nothing relevant on logs

Steps to reproduce

  1. Go to the Library using a controller
  2. Open the context menu for any game card (X on an Xbox controller)
  3. Move the stick/pad down to focus different items
  4. The colors issue shows up
  5. Move the mouse
  6. The colors issue is gone

Expected behavior

The controller-focused element should be bright like the color used for the mouse hover. The first element should not stay highlighted when changing items.

Screenshots

Added above

System Information

  • OS [e. g. "Ubuntu"]: happens on any system
  • Heroic Version [e. g. 2.1.1]: main branch

Additional information

No response

@arielj arielj added the good first issue Good for newcomers. label Oct 15, 2022
@arielj arielj closed this as completed Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers.
Projects
None yet
Development

No branches or pull requests

1 participant