Skip to content

Install button shouldn't work if install path is empty #1234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arielj opened this issue Apr 24, 2022 · 3 comments
Closed

Install button shouldn't work if install path is empty #1234

arielj opened this issue Apr 24, 2022 · 3 comments
Assignees
Labels
bug:confirmed Something isn't working. issue:investigating This issue is being actively investigated. Linux pr:ready-for-review Feature-complete, ready for the grind! :P

Comments

@arielj
Copy link
Collaborator

arielj commented Apr 24, 2022

Describe the bug

When trying to install a game, if the install path is empty, clicking the Install button closes the dialog with no information and nothing happens, and there's no indication of an error anywhere.

Add logs

not relevant

Steps to reproduce

  1. Open the install dialog for a game
  2. Make sure the Select Install Path field is empty
  3. Click the Install button
  4. Dialog closes, installation never starts, no errors are displayed anywhere (the code simply returns)

Expected behavior

Clicking the Install button shouldn't close the dialog and it should be clear what's the reason it's not installing.

I can imagine 2 options:

  • disable the Install button if the input is empty (though we still need to show some indication that it can't be empty)
  • leave the button enabled but show a message to the user if the input is empty

Screenshots

No response

System Information

  • OS [e. g. "Ubuntu"]: Linux Mint
  • Heroic Version [e. g. 2.1.1]: 2.3.0-beta.1

Additional information

No response

@philipwilk philipwilk added bug:unconfirmed Someone works on identifying the issue Linux bug:confirmed Something isn't working. issue:investigating This issue is being actively investigated. and removed bug:unconfirmed Someone works on identifying the issue labels Apr 24, 2022
@philipwilk
Copy link
Collaborator

I see what you mean, I'm taking a look.

@philipwilk philipwilk self-assigned this Apr 25, 2022
@philipwilk
Copy link
Collaborator

Made a patch on #1239

@philipwilk philipwilk added the pr:ready-for-review Feature-complete, ready for the grind! :P label Apr 25, 2022
@flavioislima
Copy link
Member

fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:confirmed Something isn't working. issue:investigating This issue is being actively investigated. Linux pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

No branches or pull requests

3 participants