Snap package management thread

[soumyaDghosh]

@flavioislima Creating this thread to discuss regarding the snap package.

name: heroic
base: core22 
version: '2.9.2' 
summary: Single-line elevator pitch for your amazing snap 
description: |
  This is my-snap's description. You have a paragraph or two to tell the
  most important story about your snap. Keep it under 100 words though,
  we live in tweetspace and your description wants to look good in the snap
  store.

grade: devel
confinement: devmode 
compression: lzo

parts:
  heroic:
    plugin: dump
    source: https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/releases/download/v$SNAPCRAFT_PROJECT_VERSION/heroic_$SNAPCRAFT_PROJECT_VERSION_$CRAFT_TARGET_ARCH.deb
    
apps:
  heroic:
    command: opt/Heroic/heroic
    desktop: usr/share/applications/heroic.desktop
    environment:
      TMPDIR: $XDG_RUNTIME_DIR
    extensions:
      - gnome

This is the current starter yaml. But, obviously this would change a lot. Now, the first thing that needs to be changed upstream is

(11:24:10) INFO:    [Legendary]:        Running command: XDG_CONFIG_HOME=/home/soumyaxubuntu/.config/heroic/legendaryConfig /opt/Heroic/resources/app.asar.unpacked/build/bin/linux/legendary --version
(11:24:10) INFO:    [Gog]:              Running command: /opt/Heroic/resources/app.asar.unpacked/build/bin/linux/gogdl --auth-config-path /home/soumyaxubuntu/.config/heroic/gog_store/auth.json --version
(11:24:10) INFO:    [Nile]:             Running command: XDG_CONFIG_HOME=/home/soumyaxubuntu/.config/heroic/nile_config /opt/Heroic/resources/app.asar.unpacked/build/bin/linux/nile --version

The XDG_CONFIG_HOME should be changed to /home/soumyaxubuntu/snap/heroic/x1/.config which is the real one for snaps. I guess the app is forcing XDG_CONFIG_HOME while running.

[flavioislima]

Thanks again for looking into that @soumyaDghosh.

I believe we are doing this to avoid conflicts when someone is using legendary standalone along with Heroic.
We can add an if check to use another path if we are able to detect we are under a snap config.
How can we do that? checking if some snap env variable is setup? that should work I believe, I will try.

Line of code if you want to take a look:

HeroicGamesLauncher/src/backend/storeManagers/legendary/library.ts

Line 669 in 1020e7e

options.env.XDG_CONFIG_HOME = dirname(legendaryConfigPath)

I will try locally to see if it fixes the Epic login issue.

[soumyaDghosh]

We can check for the existense of an environment variable SNAP. Okay, now I will add up extra things. One by one.

EDIT: No change is necessary. Everything is fine.

[flavioislima]

That did the trick, one problem solved! 🎉

Now we need to figure it out how to have access to curl, gamemode, mangohud, gamescope and the Steam and Lutris folders.

[flavioislima]

Yes this is Wayland :D
But I generated the snap using electron-builder for now. If we can make it work with it is better because then I don't need to change the CI workflows that are already working for Snaps so they get updated automatically on every release.

This is the current yml generated by it:

base: core20
grade: stable
confinement: strict
plugs:
  gnome-3-28-1804:
    interface: content
    target: $SNAP/gnome-platform
    default-provider: gnome-3-28-1804
  gtk-3-themes:
    interface: content
    target: $SNAP/data-dir/themes
    default-provider: gtk-common-themes
  icon-themes:
    interface: content
    target: $SNAP/data-dir/icons
    default-provider: gtk-common-themes
  sound-themes:
    interface: content
    target: $SNAP/data-dir/sounds
    default-provider: gtk-common-themes
  dot-local-share:
    interface: personal-files
    write:
      - $HOME/.local/share/Steam
      - $HOME/.local/share/lutris
name: heroic
version: 2.9.2
title: Heroic
summary: Heroic
description: Heroic is an Open Source Games Launcher. Right now it supports launching games from the Epic Games Store using Legendary and GOG Games using our custom implementation with gogdl.
architectures:
  - amd64
apps:
  heroic:
    command: command.sh
    plugs:
      - desktop
      - desktop-legacy
      - home
      - x11
      - wayland
      - unity7
      - browser-support
      - network
      - gsettings
      - audio-playback
      - pulseaudio
      - opengl
      - dot-local-share
    environment:
      DISABLE_WAYLAND: ''
      PATH: $SNAP/usr/sbin:$SNAP/usr/bin:$SNAP/sbin:$SNAP/bin:$PATH
      SNAP_DESKTOP_RUNTIME: $SNAP/gnome-platform
      LD_LIBRARY_PATH: $SNAP_LIBRARY_PATH:$SNAP/lib:$SNAP/usr/lib:$SNAP/lib/x86_64-linux-gnu:$SNAP/usr/lib/x86_64-linux-gnu:$LD_LIBRARY_PATH:$SNAP/lib:$SNAP/usr/lib:$SNAP/lib/x86_64-linux-gnu:$SNAP/usr/lib/x86_64-linux-gnu

[soumyaDghosh]

No not wayland,

DISABLE_WAYLAND: ''

That one I shared doesn't have this. But, electron builder will put this by default.

[flavioislima]

Maybe because I used this variable: "allowNativeWayland": true.
I will remove it and try.

BTW, lets discuss on the PR instead so we can keep everything there.

[soumyaDghosh]

@flavioislima got back again. Questions,

(19:18:46) WARNING: [Winetricks]:       Error Downloading Winetricks Error: error request aborted
    at createError (/snap/heroic/x13/opt/Heroic/resources/app.asar/node_modules/axios/lib/core/createError.js:16:15)
    at IncomingMessage.handlerStreamAborted (/snap/heroic/x13/opt/Heroic/resources/app.asar/node_modules/axios/lib/adapters/http.js:301:18)
    at IncomingMessage.emit (node:events:514:28)
    at IncomingMessage._destroy (node:_http_incoming:224:10)
    at _destroy (node:internal/streams/destroy:109:10)
    at IncomingMessage.destroy (node:internal/streams/destroy:71:5)
    at TLSSocket.socketCloseListener (node:_http_client:461:11)
    at TLSSocket.emit (node:events:526:35)
    at node:net:323:12
    at TCP.done (node:_tls_wrap:588:7) {

what's this error about?

2.03%)
Warning: vkCreateInstance: Found no drivers!
Warning: vkCreateInstance failed with VK_ERROR_INCOMPATIBLE_DRIVER
    at CheckVkSuccessImpl (../../third_party/dawn/src/dawn/native/vulkan/VulkanError.cpp:88)
    at CreateVkInstance (../../third_party/dawn/src/dawn/native/vulkan/BackendVk.cpp:458)
    at Initialize (../../third_party/dawn/src/dawn/native/vulkan/BackendVk.cpp:344)
    at Create (../../third_party/dawn/src/dawn/native/vulkan/BackendVk.cpp:266)
    at operator() (../../third_party/dawn/src/dawn/native/vulkan/BackendVk.cpp:521)

886079
    at EasyDl.<anonymous> (/snap/heroic/x13/opt/Heroic/resources/app.asar/node_modules/easydl/dist/index.js:348:32)
    at Generator.next (<anonymous>)
    at fulfilled (/snap/heroic/x13/opt/Heroic/resources/app.asar/node_modules/easydl/dist/index.js:24:58)
(19:24:48) ERROR:   [DownloadManager]:  Downloader: Download Failed with: Error: Failed to download chunk #7 73400320,83886079
(19:24:48) ERROR:   [WineDownloader]:   Error: Download of Wine-GE-Proton8-27-LoL failed with:
 Error: Download failed with Error: Failed to download chunk #7 73400320,83886079
    at /snap/heroic/x13/opt/Heroic/resources/app.asar/build/electron/main.52896897.js:108:444
    at async installVersion (/snap/heroic/x13/opt/Heroic/resources/app.asar/build/electron/main.52896897.js:108:271)
    at async installWineVersion (/snap/heroic/x13/opt/Heroic/resources/app.asar/build/electron/main.52896897.js:111:1844)
    at async downloadDefaultWine (/snap/heroic/x13/opt/Heroic/resources/app.asar/build/electron/main.52896897.js:118:456)
(19:24:48) ERROR:   [Backend]:          Error: Failed to download chunk #6 62914560,73400319
    at EasyDl.<anonymous> (/snap/heroic/x13/opt/Heroic/resources/app.asar/node_modules/easydl/dist/index.js:348:32)
    at Generator.next (<anonymous>)
    at fulfilled (/snap/heroic/x13/opt/Heroic/resources/app.asar/node_modules/easydl/dist/index.js:24:58)

got this on the first startup

[soumyaDghosh]

@flavioislima @arielj pinging for response.

[soumyaDghosh]

I have almost reached to the root cause probably. Now, the things that I faced are

1. The snap is not able to install vkd3d properly. It's just downloading and decompressing the file. But after that it's gone.
2. Heroic probably reads/writes on /var/tmp, can we change it to TEMPDIR or to any directory else?
3. The snap uses FileManager1 to open File Manager, but currently that's not supported in snapd. We can fallback to portals.

[vrement]

Was looking for Heroic Games Launcher in Ubuntu's App Center, then started looking for the cause its not there and ended up here. So then, i see there i some kind of building trouble. Is a working snap getting any closer?

Thanks alot if any word.

[hifron]

bwrap trouble and similars... Ubuntu has also default restrictions on 24.04 upward. Apparmor profile is probably required in Heroic.deb, in AppImage it is problematic and Flatpak is officially unsupported on Ubuntu, yet still installable.

Also insisting on steam installed for ProtonGE is maybe problem when steam snap installed instead... Problem even worser could be winetricks(there is also protontricks) which depends in theory on banned Microsoft libs and assets which a lot of them are not longer downloadable from MS or even insist on official MS license or rent but maybe not download option even from MS page which winetricks for a long time(and some Ubuntu packages like for ttf) think so, so freetype and similar could be problem...

[vrement]

Any tangible progress yet? Thanks.