review comments

Etaash-mathamsetty · Etaash-mathamsetty · commit fc2f2c75f8d4 · 2024-01-31T17:22:45.000-05:00
diff --git a/src/backend/launcher.ts b/src/backend/launcher.ts
@@ -212,7 +212,7 @@ async function prepareLaunch(
       }
 
       gameScopeCommand.push(
-        ...shlex.split(gameSettings.gamescope.additionalOptions)
+        ...shlex.split(gameSettings.gamescope.additionalOptions ?? '')
       )
 
       // Note: needs to be the last option
diff --git a/src/frontend/screens/Settings/components/Gamescope.tsx b/src/frontend/screens/Settings/components/Gamescope.tsx
@@ -369,7 +369,7 @@ const Gamescope = () => {
             )}
           />
         }
-        onChange={(event: ChangeEvent<HTMLInputElement>) =>
+        onBlur={(event: ChangeEvent<HTMLInputElement>) =>
           setGamescope({
             ...gamescope,
             additionalOptions: event.currentTarget.value

Original file line number	Diff line number	Diff line change
`@@ -212,7 +212,7 @@ async function prepareLaunch(`
`212`	`212`	`}`
`213`	`213`
`214`	`214`	`gameScopeCommand.push(`
`215`		`- ...shlex.split(gameSettings.gamescope.additionalOptions)`
	`215`	`+ ...shlex.split(gameSettings.gamescope.additionalOptions ?? '')`
`216`	`216`	`)`
`217`	`217`
`218`	`218`	`// Note: needs to be the last option`
Original file line number	Diff line number	Diff line change
`@@ -369,7 +369,7 @@ const Gamescope = () => {`
`369`	`369`	`)}`
`370`	`370`	`/>`
`371`	`371`	`}`
`372`		`- onChange={(event: ChangeEvent<HTMLInputElement>) =>`
	`372`	`+ onBlur={(event: ChangeEvent<HTMLInputElement>) =>`
`373`	`373`	`setGamescope({`
`374`	`374`	`...gamescope,`
`375`	`375`	`additionalOptions: event.currentTarget.value`