add '--no-https' to legendary args for LanCache compatibility

This flag can be enabled via the advanced settings and gets applied to the uses of legendary commands "install", "update" and "repair".

Author: Jan B

electron/legendary/games.ts

@@ -293,11 +293,13 @@ class LegendaryGame extends Game {
       status: 'updating'
     })
     const { maxWorkers } = await GlobalConfig.get().getSettings()
+    const { downloadNoHttps } = await GlobalConfig.get().getSettings()
     const info = await Game.get(this.appName, 'legendary').getInstallInfo()
     const workers = maxWorkers ? ['--max-workers', `${maxWorkers}`] : []
+    const noHttps = downloadNoHttps ? ['--no-https'] : []
     const logPath = join(heroicGamesConfigPath, this.appName + '.log')
 
-    const commandParts = ['update', this.appName, ...workers, '-y']
+    const commandParts = ['update', this.appName, ...workers, ...noHttps, '-y']
     const command = getLegendaryCommand(commandParts)
 
     logInfo([`Updating ${this.appName} with:`, command], LogPrefix.Legendary)
@@ -370,10 +372,12 @@ class LegendaryGame extends Game {
     platformToInstall
   }: InstallArgs): Promise<{ status: 'done' | 'error' }> {
     const { maxWorkers } = await GlobalConfig.get().getSettings()
+    const { downloadNoHttps } = await GlobalConfig.get().getSettings()
     const info = await Game.get(this.appName, 'legendary').getInstallInfo(
       platformToInstall
     )
     const workers = maxWorkers ? ['--max-workers', `${maxWorkers}`] : []
+    const noHttps = downloadNoHttps ? ['--no-https'] : []
     const withDlcs = installDlcs ? '--with-dlcs' : '--skip-dlcs'
     const installSdl = sdlList.length
       ? this.getSdlList(sdlList)
@@ -391,6 +395,7 @@ class LegendaryGame extends Game {
       withDlcs,
       ...installSdl,
       ...workers,
+      ...noHttps,
       '-y'
     ]
     const command = getLegendaryCommand(commandParts)
@@ -458,11 +463,13 @@ class LegendaryGame extends Game {
   public async repair(): Promise<ExecResult> {
     // this.state.status = 'repairing'
     const { maxWorkers } = await GlobalConfig.get().getSettings()
+    const { downloadNoHttps } = await GlobalConfig.get().getSettings()
     const workers = maxWorkers ? ['--max-workers', `${maxWorkers}`] : []
+    const noHttps = downloadNoHttps ? ['--no-https'] : []
 
     const logPath = join(heroicGamesConfigPath, this.appName + '.log')
 
-    const commandParts = ['repair', this.appName, ...workers, '-y']
+    const commandParts = ['repair', this.appName, ...workers, ...noHttps, '-y']
     const command = getLegendaryCommand(commandParts)
 
     logInfo([`Repairing ${this.appName}:`, command], LogPrefix.Legendary)

electron/types.ts

@@ -22,6 +22,7 @@ export interface AppSettings {
   defaultInstallPath: string
   disableController: boolean
   discordRPC: boolean
+  downloadNoHttps: boolean
   egsLinkedPath: string
   exitToTray: boolean
   enableEsync: boolean

src/screens/Settings/components/AdvancedSettings/index.tsx

@@ -7,6 +7,7 @@ import {
 import classNames from 'classnames'
 import { IpcRenderer, Clipboard } from 'electron'
 import { useTranslation } from 'react-i18next'
+import { ToggleSwitch } from 'src/components/UI'
 import React, { useEffect, useState } from 'react'
 import { AppSettings, Path } from 'src/types'
 import { configStore } from 'src/helpers/electronStores'
@@ -24,16 +25,20 @@ const { ipcRenderer, clipboard } = window.require('electron') as ElectronProps
 interface Props {
   altLegendaryBin: string
   altGogdlBin: string
+  downloadNoHttps: boolean
   setAltLegendaryBin: (value: string) => void
   setAltGogdlBin: (value: string) => void
+  toggleDownloadNoHttps: () => void
   settingsToSave: AppSettings
 }
 
 export const AdvancedSettings = ({
   altLegendaryBin,
   altGogdlBin,
+  downloadNoHttps,
   setAltLegendaryBin,
   setAltGogdlBin,
+  toggleDownloadNoHttps,
   settingsToSave
 }: Props) => {
   const [legendaryVersion, setLegendaryVersion] = useState('')
@@ -210,6 +215,16 @@ export const AdvancedSettings = ({
         }
       />
 
+      <ToggleSwitch
+        htmlId="downloadNoHttps"
+        value={downloadNoHttps}
+        handleChange={toggleDownloadNoHttps}
+        title={t(
+          'setting.download-no-https',
+          'Download games without HTTPS (useful for CDNs e.g. LanCache)'
+        )}
+      />
+
       <div className="footerFlex">
         <button
           className={classNames('button', 'is-footer', {

src/screens/Settings/index.tsx

@@ -176,6 +176,11 @@ function Settings() {
     toggle: toggleDisableController,
     setOn: setDisableController
   } = useToggle(false)
+  const {
+    on: downloadNoHttps,
+    toggle: toggleDownloadNoHttps,
+    setOn: setDownloadNoHttps
+  } = useToggle(false)
 
   const [autoSyncSaves, setAutoSyncSaves] = useState(false)
   const [altWine, setAltWine] = useState([] as WineInstallation[])
@@ -236,6 +241,7 @@ function Settings() {
       setDefaultWinePrefix(config.defaultWinePrefix)
       setUseSteamRuntime(config.useSteamRuntime)
       setDisableController(config.disableController || false)
+      setDownloadNoHttps(config.downloadNoHttps)
 
       if (!isDefault) {
         const { title: gameTitle, canRunOffline: can_run_offline } =
@@ -267,6 +273,7 @@ function Settings() {
     defaultWinePrefix,
     disableController,
     discordRPC,
+    downloadNoHttps,
     egsLinkedPath,
     enableEsync,
     enableFsync,
@@ -473,6 +480,8 @@ function Settings() {
               setAltLegendaryBin={setAltLegendaryBin}
               altGogdlBin={altGogdlBin}
               setAltGogdlBin={setAltGogdlBin}
+              downloadNoHttps={downloadNoHttps}
+              toggleDownloadNoHttps={toggleDownloadNoHttps}
               settingsToSave={settingsToSave}
             />
           )}

src/types.ts

@@ -18,6 +18,7 @@ export interface AppSettings {
   defaultInstallPath: string
   disableController: boolean
   discordRPC: boolean
+  downloadNoHttps: boolean
   egsLinkedPath: string
   exitToTray: boolean
   enableEsync: boolean