Skip to content

Commit 396e1d0

Browse files
committed
Use standalone version of pnpm to fix electron-builder issues
1 parent 1284a7e commit 396e1d0

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

.github/actions/install-deps/action.yml

+1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ runs:
99
- uses: pnpm/action-setup@v3
1010
with:
1111
version: 8
12+
standalone: true
1213
- name: Install node-gyp
1314
run: pnpm add --global node-gyp
1415
shell: bash

README.md

+4-2
Original file line numberDiff line numberDiff line change
@@ -207,15 +207,17 @@ Otherwise, download the file ending in .dmg from the [latest release](https://gi
207207

208208
This part will walk you through setting up a development environment so you can build Heroic binaries yourself or make changes to the code.
209209

210-
1. Make sure Git, NodeJS, and PNPM are installed
210+
1. Make sure Git, NodeJS, and PNPM are installed
211+
**NOTE**: Due to an issue with electron-builder, you'll need the standalone version of pnpm (`@pnpm/exe`) to build
212+
packages
211213
2. Clone the repo and enter the cloned folder, for example with these commands:
212214

213215
```bash
214216
git clone https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher.git --recurse-submodules
215217
cd HeroicGamesLauncher
216218
```
217219

218-
3. Make sure all dependencies are installed by running `pnpm`
220+
3. Make sure all dependencies are installed by running `pnpm install`
219221

220222
### Building Heroic Binaries
221223

0 commit comments

Comments
 (0)