Skip to content

Commit 32e16d4

Browse files
authored
[UI/UX] Fix some visual issues related to logs, dialogs, and RTL layout (#3207)
Fix some visual issues related to logs, dialogs, and RTL layout
1 parent b95abc8 commit 32e16d4

File tree

6 files changed

+28
-6
lines changed

6 files changed

+28
-6
lines changed

src/frontend/components/UI/Sidebar/index.scss

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -209,6 +209,12 @@
209209
padding: var(--space-2xs) 0;
210210
}
211211

212+
.isRTL .Sidebar.collapsed .SidebarItemWithSubmenu:hover .SidebarSubmenu,
213+
.isRTL .Sidebar.collapsed .SidebarItemWithSubmenu:focus-within .SidebarSubmenu {
214+
right: var(--sidebar-width);
215+
left: auto;
216+
}
217+
212218
.Sidebar.collapsed .SidebarItemWithSubmenu:hover .SidebarSubmenu.settings,
213219
.Sidebar.collapsed
214220
.SidebarItemWithSubmenu:focus-within

src/frontend/index.scss

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,11 @@ body {
7575
background: var(--accent);
7676
}
7777

78+
::-webkit-scrollbar-corner,
79+
::-webkit-resizer {
80+
background: var(--gradient-body-background, var(--body-background));
81+
}
82+
7883
.simple-keyboard {
7984
position: absolute;
8085
z-index: 10;

src/frontend/screens/Game/GamePage/index.scss

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@
143143
}
144144
}
145145

146-
.isRTL {
146+
&.isRTL {
147147
.gameTools {
148148
right: auto !important;
149149
left: 0px;
@@ -156,6 +156,10 @@
156156
left: auto !important;
157157
right: 1rem;
158158
}
159+
.backButton {
160+
left: auto !important;
161+
right: 12px;
162+
}
159163
}
160164

161165
.gameConfig {

src/frontend/screens/Library/components/InstallModal/index.scss

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
.InstallModal__dialog {
2-
width: 38vw;
3-
height: fit-content;
2+
width: 700px;
3+
min-height: fit-content;
44
min-width: fit-content;
5-
max-height: 95vh;
5+
max-width: 80vw;
6+
height: 90vh;
7+
max-height: 1000px;
68
}
79

810
.InstallModal__dialog > .anticheatInfo {

src/frontend/screens/Settings/sections/LogSettings/index.css

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,12 @@
88
grid-template-rows: 1fr;
99
column-gap: 0.5rem;
1010
height: 25em;
11+
width: 100%;
1112

1213
.log-buttongroup {
1314
display: flex;
1415
flex-direction: column;
15-
width: 150px;
16+
width: 180px;
1617
gap: 1rem;
1718
overflow-y: auto;
1819
overflow-x: hidden;

src/frontend/state/GlobalState.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -790,9 +790,13 @@ class GlobalState extends PureComponent<Props> {
790790
libraryStatus,
791791
sidebarCollapsed,
792792
hideChangelogsOnStartup,
793-
lastChangelogShown
793+
lastChangelogShown,
794+
language
794795
} = this.state
795796

797+
const isRTL = RTL_LANGUAGES.includes(language)
798+
document.body.classList.toggle('isRTL', isRTL)
799+
796800
storage.setItem('updates', JSON.stringify(gameUpdates))
797801
storage.setItem('sidebar_collapsed', JSON.stringify(sidebarCollapsed))
798802
storage.setItem('hide_changelogs', JSON.stringify(hideChangelogsOnStartup))

0 commit comments

Comments
 (0)