Fix carpet extension display (#140)

* Fix compat api wrong return value

* Migrating initialisation parameters to constructors

---------

Signed-off-by: Hendrix-Shen <[email protected]>

Author: Hendrix-Shen

magiclib-legacy-compat/src/main/java/top/hendrixshen/magiclib/impl/carpet/CarpetEntrypoint.java

@@ -26,9 +26,7 @@ public static void init() {
                                 .orElseThrow(RuntimeException::new)
                 },
                 SharedConstants.getMagiclibIdentifier(),
-                new MagicLibSettingManager(SharedConstants.getMagiclibIdentifier(),
-                        SharedConstants.getMagiclibIdentifier(),
-                        SharedConstants.getMagiclibName()),
+                new MagicLibSettingManager(),
                 ReflectionUtil.newInstance("top.hendrixshen.magiclib.impl.carpet.MagicLibAddition", null)
                         .orElseThrow(RuntimeException::new));
     }

magiclib-legacy-compat/src/main/java/top/hendrixshen/magiclib/impl/carpet/MagicLibSettingManager.java

@@ -1,9 +1,10 @@
 package top.hendrixshen.magiclib.impl.carpet;
 
+import top.hendrixshen.magiclib.SharedConstants;
 import top.hendrixshen.magiclib.carpet.impl.WrappedSettingManager;
 
 public class MagicLibSettingManager extends WrappedSettingManager {
-    public MagicLibSettingManager(String version, String identifier, String fancyName) {
-        super(version, identifier, fancyName);
+    public MagicLibSettingManager() {
+        super(SharedConstants.getMagiclibVersion(), SharedConstants.getMagiclibIdentifier(), SharedConstants.getMagiclibName());
     }
 }

magiclib-minecraft-api/src/main/java/top/hendrixshen/magiclib/util/minecraft/ComponentUtil.java

@@ -305,11 +305,9 @@ public static MutableComponentCompat propertyCompat(Property<?> property, Object
 
     public static @NotNull MutableComponentCompat joinCompat(
             MutableComponentCompat joiner, @NotNull Iterable<MutableComponentCompat> items) {
-        MutableComponentCompat text = ComponentUtil.emptyCompat();
-        ComponentUtil.join(text.get(), StreamSupport.stream(items.spliterator(), false)
+        return MutableComponentCompat.of(ComponentUtil.join(joiner.get(), StreamSupport.stream(items.spliterator(), false)
                 .map(MutableComponentCompat::get)
-                .collect(Collectors.toList()));
-        return text;
+                .collect(Collectors.toList())));
     }
 
     public static @NotNull BaseComponent join(BaseComponent joiner, BaseComponent... items) {