Merge pull request #740 from HathorNetwork/release-candidate

Release v1.10.0

Author: pedroferreira1

.eslintrc.js

@@ -9,6 +9,7 @@ module.exports = {
   parserOptions: {
     ecmaVersion: 2023, // Allows for the parsing of modern ECMAScript features
     sourceType: 'module', // Allows for the use of imports
+    project: ['./tsconfig.json', './tsconfig.test.json'],
   },
   settings: {
     'import/resolver': {
@@ -54,6 +55,7 @@ module.exports = {
       {
         vars: 'all',
         args: 'none', // We should change to args: after-used
+        varsIgnorePattern: '^_', // Allow variables starting with _ to be unused
       },
     ],
     'no-underscore-dangle': 0,
@@ -70,6 +72,7 @@ module.exports = {
         ts: 'never',
       },
     ],
+    'jest/no-disabled-tests': 'off', // It's useful to have skipped tests on our suites
 
     /* These last rules would require a large effort and potentially cause breaking changes,
      * So they will be left out for now and dealt with separately.
@@ -92,6 +95,33 @@ module.exports = {
       },
       plugins: ['jest'],
       extends: ['plugin:jest/recommended'], // Use recommended Jest rules
+      rules: {
+        'jest/no-disabled-tests': 'off', // It's useful to have skipped tests on our suites
+        "jest/expect-expect": [
+          'error',
+          {
+            assertFunctionNames: [
+              'expect',
+              'executeTests', // from NanoContracts bet tests
+              'testUnlockWhenSpent', // from Nano contracts Storage tests
+              'testLockedUtxoMethods', // from Common Store tests
+              'testRegisteredTokens', // from Common Store tests
+              'testScanningPolicies', // from Common Store tests
+              'testBestUtxoSelection', // from utxo test
+              'testFastUtxoSelection', // from utxo test
+              'handleStopTest', // from storage test
+              'processLockedUtxoTest', // from storage test
+              'getChangeAddressTest', // from storage test
+              'getAcctXprivTest', // from storage test
+              'accessDataTest', // from storage test
+              'checkPinTest', // from storage test
+              'checkPasswdTest', // from storage test
+              'testSelectUtxos', // from storage test
+              'testScanningPolicy', // from storage test
+            ],
+          },
+        ],
+      },
     },
   ],
 };

.github/workflows/integration-test.yml

@@ -1,5 +1,12 @@
 name: integration-test
 on:
+  push:
+    branches:
+      - master
+      - release
+      - release-candidate
+    tags:
+      - v*
   pull_request:
     branches:
       - release
@@ -37,8 +44,8 @@ jobs:
 
       - name: Upload debug transaction logs
         if: always()
-        # https://github.com/actions/upload-artifact/releases/tag/v3.1.2
-        uses: actions/upload-artifact@0b7f8abb1508181956e8e162db84b466c27e18ce
+        # https://github.com/actions/upload-artifact/releases/tag/v4.3.6
+        uses: actions/upload-artifact@834a144ee995460fba8ed112a2fc961b36a5ec5a
         with:
           name: test-transacion-logs
           path: tmp
@@ -64,8 +71,8 @@ jobs:
 
       - name: Upload logs to GitHub
         if: failure()
-        # https://github.com/actions/upload-artifact/releases/tag/v3.1.2
-        uses: actions/upload-artifact@0b7f8abb1508181956e8e162db84b466c27e18ce
+        # https://github.com/actions/upload-artifact/releases/tag/v4.3.6
+        uses: actions/upload-artifact@834a144ee995460fba8ed112a2fc961b36a5ec5a
         with:
           name: logs.tgz
           path: ./docker-logs.tgz

.github/workflows/release-sync.yml

@@ -2,7 +2,6 @@ name: Sync Release with Master
 
 # Triggered when a new version is released publicly
 on:
-  workflow_dispatch:
   release:
     types: [ released ]
 

__tests__/__fixtures__/sample_txs.js renamed to __tests__/__fixtures__/sample_txs.ts

@@ -2,6 +2,9 @@ export default [
   {
     tx_id: '0000000110eb9ec96e255a09d6ae7d856bff53453773bae5500cee2905db670e',
     version: 0,
+    signalBits: 0,
+    nonce: 0,
+    tokens: [],
     weight: 22.719884359974895,
     timestamp: 1613538740,
     is_voided: false,
@@ -31,6 +34,9 @@ export default [
   {
     tx_id: '0000000211673128a49ea700c7b3efbbbc4b3bfe5bf289bc5a1967f12d3c30b5',
     version: 0,
+    signalBits: 0,
+    nonce: 0,
+    tokens: [],
     weight: 21.911255937644835,
     timestamp: 1613519819,
     is_voided: false,
@@ -60,6 +66,9 @@ export default [
   {
     tx_id: '0000000292236abbb41a2201409b85084631389950f76f7da0d8734b51b31758',
     version: 0,
+    signalBits: 0,
+    nonce: 0,
+    tokens: [],
     weight: 22.255565408819944,
     timestamp: 1613524608,
     is_voided: false,
@@ -89,6 +98,9 @@ export default [
   {
     tx_id: '00000003508b2c24066365cffe23cd77896dad01a665c64cd4797654c6acab92',
     version: 0,
+    signalBits: 0,
+    nonce: 0,
+    tokens: [],
     weight: 21.7848190101318,
     timestamp: 1613529833,
     is_voided: true,
@@ -118,6 +130,9 @@ export default [
   {
     tx_id: '0000000419625e2587c225fb49f36278c9da681ec05e039125307b8aef3d3d30',
     version: 0,
+    signalBits: 0,
+    nonce: 0,
+    tokens: [],
     weight: 22.227347437740097,
     timestamp: 1613522627,
     is_voided: false,
@@ -147,6 +162,9 @@ export default [
   {
     tx_id: '0000000fa2157d34a56b89c08e1783cd1103f6e6807bb01ccff1d920b31d1052',
     version: 0,
+    signalBits: 0,
+    nonce: 0,
+    tokens: [],
     weight: 26.450454121121226,
     timestamp: 1613678350,
     is_voided: false,
@@ -176,6 +194,9 @@ export default [
   {
     tx_id: '0000000fa2157d34a56b89c08e1783cd1103f6e6807bb01ccff1d920b31d1053',
     version: 0,
+    signalBits: 0,
+    nonce: 0,
+    tokens: [],
     weight: 26.450454121121226,
     timestamp: 1613678350,
     is_voided: false,
@@ -205,6 +226,9 @@ export default [
   {
     tx_id: '0000000fa2157d34a56b89c08e1783cd1103f6e6807bb01ccff1d920b31d1054',
     version: 0,
+    signalBits: 0,
+    nonce: 0,
+    tokens: [],
     weight: 26.450454121121226,
     timestamp: 1613678350,
     is_voided: false,
@@ -234,6 +258,9 @@ export default [
   {
     tx_id: '0000000fa2157d34a56b89c08e1783cd1103f6e6807bb01ccff1d920b31d1055',
     version: 0,
+    signalBits: 0,
+    nonce: 0,
+    tokens: [],
     weight: 26.450454121121226,
     timestamp: 1613678350,
     is_voided: false,
@@ -263,6 +290,9 @@ export default [
   {
     tx_id: '0000000fa2157d34a56b89c08e1783cd1103f6e6807bb01ccff1d920b31d1056',
     version: 0,
+    signalBits: 0,
+    nonce: 0,
+    tokens: [],
     weight: 26.450454121121226,
     timestamp: 1613678370,
     is_voided: false,
@@ -292,6 +322,9 @@ export default [
   {
     tx_id: '0000000fa2157d34a56b89c08e1783cd1103f6e6807bb01ccff1d920b31d1057',
     version: 0,
+    signalBits: 0,
+    nonce: 0,
+    tokens: [],
     weight: 26.450454121121226,
     timestamp: 1613678370,
     is_voided: false,

__tests__/__fixtures__/tx_history.js renamed to __tests__/__fixtures__/tx_history.ts

@@ -1,5 +1,5 @@
 import MockAdapter from 'axios-mock-adapter';
-import axios from 'axios';
+import axios, { AxiosError } from 'axios';
 import txMiningApi from '../../src/api/txMining';
 
 describe('txMiningApi', () => {
@@ -37,12 +37,15 @@ describe('txMiningApi', () => {
     it('should allow capturing errors in case the server responds with 500', async () => {
       mock.onGet('job-status').reply(500);
 
+      let err: unknown;
       try {
         await txMiningApi.getJobStatus('jobId', () => {});
       } catch (e) {
-        expect(e.message).toEqual('Request failed with status code 500');
-        expect(e.response.status).toEqual(500);
+        err = e;
       }
+      expect(err).toBeInstanceOf(AxiosError);
+      expect((err as AxiosError).message).toEqual('Request failed with status code 500');
+      expect((err as AxiosError).response?.status).toEqual(500);
     });
   });
 
@@ -70,12 +73,14 @@ describe('txMiningApi', () => {
     it('should allow capturing errors in case the server responds with 500', async () => {
       mock.onPost('cancel-job').reply(500);
 
+      let err: unknown;
       try {
         await txMiningApi.cancelJob('jobId', () => {});
       } catch (e) {
-        expect(e.message).toEqual('Request failed with status code 500');
-        expect(e.response.status).toEqual(500);
+        err = e;
       }
+      expect((err as AxiosError).message).toEqual('Request failed with status code 500');
+      expect((err as AxiosError).response?.status).toEqual(500);
     });
   });
 
@@ -98,12 +103,14 @@ describe('txMiningApi', () => {
     it('should allow capturing errors in case the server responds with 500', async () => {
       mock.onGet('health').reply(500);
 
+      let err: unknown;
       try {
         await txMiningApi.getHealth();
       } catch (e) {
-        expect(e.message).toEqual('Request failed with status code 500');
-        expect(e.response.status).toEqual(500);
+        err = e;
       }
+      expect((err as AxiosError).message).toEqual('Request failed with status code 500');
+      expect((err as AxiosError).response?.status).toEqual(500);
     });
   });
 
@@ -138,12 +145,14 @@ describe('txMiningApi', () => {
     it('should allow capturing errors in case the server responds with 500', async () => {
       mock.onPost('submit-job').reply(500);
 
+      let err: unknown;
       try {
         await txMiningApi.submitJob('tx', true, true, 10, () => {});
       } catch (e) {
-        expect(e.message).toEqual('Request failed with status code 500');
-        expect(e.response.status).toEqual(500);
+        err = e;
       }
+      expect((err as AxiosError).message).toEqual('Request failed with status code 500');
+      expect((err as AxiosError).response?.status).toEqual(500);
     });
   });
 });

__tests__/__mocks__/wallet.mock.ts renamed to __tests__/__mock_helpers__/axios-adapter.mock.ts

@@ -1,5 +1,5 @@
 import MockAdapter from 'axios-mock-adapter';
-import axios from 'axios';
+import axios, { AxiosError } from 'axios';
 import versionApi from '../../src/api/version';
 
 describe('versionApi', () => {
@@ -34,12 +34,14 @@ describe('versionApi', () => {
     it('should allow capturing errors in case the server responds with 500', async () => {
       mock.onGet('/version').reply(500);
 
+      let err: unknown;
       try {
         await versionApi.getVersion(() => {});
       } catch (e) {
-        expect(e.message).toEqual('Request failed with status code 500');
-        expect(e.response.status).toEqual(500);
+        err = e;
       }
+      expect((err as AxiosError).message).toEqual('Request failed with status code 500');
+      expect((err as AxiosError).response?.status).toEqual(500);
     });
   });
 
@@ -62,12 +64,14 @@ describe('versionApi', () => {
     it('should allow capturing errors in case the server responds with 500', async () => {
       mock.onGet('/version').reply(500);
 
+      let err: unknown;
       try {
         await versionApi.asyncGetVersion();
       } catch (e) {
-        expect(e.message).toEqual('Request failed with status code 500');
-        expect(e.response.status).toEqual(500);
+        err = e;
       }
+      expect((err as AxiosError).message).toEqual('Request failed with status code 500');
+      expect((err as AxiosError).response?.status).toEqual(500);
     });
   });
 });

__tests__/__mock_helpers/fake_hathorwallet.ts renamed to __tests__/__mock_helpers__/fake_hathorwallet.ts

@@ -10,7 +10,6 @@ import { loggers } from './utils/logger.util';
 import { NATIVE_TOKEN_UID } from '../../src/constants';
 import SendTransaction from '../../src/new/sendTransaction';
 import PartialTxProposal from '../../src/wallet/partialTxProposal';
-import { delay } from './utils/core.util';
 
 describe('partial tx proposal', () => {
   afterEach(async () => {
@@ -24,11 +23,7 @@ describe('partial tx proposal', () => {
     const hWallet2 = await generateWalletHelper();
 
     // Injecting funds and creating a new custom token
-    const txI = await GenesisWalletHelper.injectFunds(
-      hWallet1,
-      await hWallet1.getAddressAtIndex(0),
-      103
-    );
+    await GenesisWalletHelper.injectFunds(hWallet1, await hWallet1.getAddressAtIndex(0), 103);
     const { hash: token1Uid } = await createTokenHelper(hWallet1, 'Token1', 'TK1', 200);
 
     // Injecting funds and creating a new custom token

__tests__/__mock_helpers/wallet-service.fixtures.ts renamed to __tests__/__mock_helpers__/wallet-service.fixtures.ts

@@ -6,7 +6,7 @@ services:
 
   fullnode:
     image:
-      ${HATHOR_LIB_INTEGRATION_TESTS_FULLNODE_IMAGE:-hathornetwork/hathor-core:experimental-nano-sdk-v1.1}
+      ${HATHOR_LIB_INTEGRATION_TESTS_FULLNODE_IMAGE:-hathornetwork/hathor-core:experimental-nano-sdk-new-types}
     command: [
       "run_node",
       "--listen", "tcp:40404",

__tests__/api/txMining.test.ts

@@ -712,6 +712,7 @@ describe('addresses methods', () => {
 
       // Validating gap limit
       if (i === 22) {
+        // eslint-disable-next-line jest/no-conditional-expect -- This is already the simplest way to test the gap limit
         expect(genResults).toStrictEqual({
           done: true,
           value: undefined,