perf: extra delays on wallet start

Author: tuliomir

__tests__/integration/multisig.test.js

@@ -92,9 +92,9 @@ describe('send tx (HTR)', () => {
       wallet5 = new WalletHelper('multisig-5', { seedKey: 'multisig-5', multisig: true });
       walletExtra = new WalletHelper('multisig-extra', { seedKey: 'multisig-extra', multisig: true });
 
-      await WalletHelper.startMultipleWalletsForTest([
-        wallet1, wallet2, wallet3, wallet4, wallet5, walletExtra],
-        { serial: true });
+      await WalletHelper.startMultipleWalletsForTest(
+        [wallet1, wallet2, wallet3, wallet4, wallet5, walletExtra]
+      );
 
       // Funds for single input/output tests
       const fundTxObj1 = await wallet1.injectFunds(1000, 0);

__tests__/integration/send-tx.test.js

@@ -672,8 +672,7 @@ describe('send tx (custom tokens)', () => {
     wallet5 = new WalletHelper('custom-tx-5');
 
     await WalletHelper.startMultipleWalletsForTest(
-      [wallet1, wallet2, wallet3, wallet4, wallet5],
-      { serial: true }
+      [wallet1, wallet2, wallet3, wallet4, wallet5]
     );
 
     // Funds for single input/output tests - 1000 HTR + 2000 custom A

__tests__/integration/utils/test-utils-integration.js

@@ -140,6 +140,8 @@ export class TestUtils {
    * @returns {Promise<{start:unknown,status:unknown}>}
    */
   static async startWallet(walletObj, options = {}) {
+    const requestStart = Date.now().valueOf();
+
     let response;
     // Request the Wallet start
     if (walletObj.words) {
@@ -156,6 +158,12 @@ export class TestUtils {
         });
     }
 
+    const requestEnd = Date.now().valueOf();
+    TestUtils.logTx('Wallet start requested', {
+      walletId: walletObj.walletId,
+      requestDuration: requestEnd - requestStart
+    })
+
     // Handle errors
     if (response.status !== 200) {
       throw new Error(`Unable to start the wallet: ${walletObj.walletId}`);
@@ -175,6 +183,12 @@ export class TestUtils {
         }
         await TestUtils.delay(1000);
       }
+
+      const readyEnd = Date.now().valueOf()
+      TestUtils.logTx('Wallet is ready', {
+        walletId: walletObj.walletId,
+        waitForReadyDuration: readyEnd - requestEnd
+      })
     }
     // Log the success and return
     if (walletObj.words) {

__tests__/integration/utils/wallet-helper.js

@@ -128,12 +128,10 @@ export class WalletHelper {
    * performance-wise.
    * @param {WalletHelper[]} walletsArr Array of WalletHelpers
    * @param [options]
-   * @param {boolean} [options.skipAddresses] Skips the getSomeAddresses command
-   * @param {number} [options.amountOfAddresses=10] How many addresses should be cached per wallet
    * @param {boolean} [options.serial] Start one wallet at a time
    * @returns {Promise<void>}
    */
-  static async startMultipleWalletsForTest(walletsArr, options) {
+  static async startMultipleWalletsForTest(walletsArr, options = {}) {
     /**
      * A map of `WalletHelper`s indexed by their `walletId`s
      * @type {Record<string,WalletHelper>}
@@ -147,30 +145,29 @@ export class WalletHelper {
       walletsArr.unshift(new WalletHelper(genesis.walletId, { words: genesis.words }));
     }
 
-    // If we need to initialize too many wallets at once, it's better to do it serially
-    if (options.serial) {
+    if (options.serial || walletsArr.length > 2) {
+      // If we need to initialize too many wallets at once, it's better to do it serially
       for (const wallet of walletsArr) {
         TestUtils.logTx('Requesting serial wallet init', {
           walletId: wallet.walletId
         })
         await TestUtils.startWallet(wallet.walletData, {
           waitWalletReady: true
         });
+        walletsPendingReady[wallet.walletId] = wallet;
       }
-
-      // Finish the function here
-      await TestUtils.pauseForWsUpdate();
-      return;
     }
-
-    // Requests the start of all the wallets in quick succession - parallel mode
-    const startPromisesArray = [];
-    for (const wallet of walletsArr) {
-      const promise = TestUtils.startWallet(wallet.walletData);
-      walletsPendingReady[wallet.walletId] = wallet;
-      startPromisesArray.push(promise);
+    else {
+      // Requests the start of all the wallets in quick succession - parallel mode
+      TestUtils.logTx('Requesting batch wallet init', { amount: walletsArr.length });
+      const startPromisesArray = [];
+      for (const wallet of walletsArr) {
+        const promise = TestUtils.startWallet(wallet.walletData);
+        walletsPendingReady[wallet.walletId] = wallet;
+        startPromisesArray.push(promise);
+      }
+      await Promise.all(startPromisesArray);
     }
-    await Promise.all(startPromisesArray);
 
     // Enters the loop checking each wallet for its status
     const timestampStart = Date.now().valueOf();