refactor: use new add_voided_by and create del_voided_by

Author: jansegre

hathor/transaction/base_transaction.py

@@ -562,9 +562,7 @@ def mark_partially_validated(self) -> None:
         """
         tx_meta = self.get_metadata()
         assert not tx_meta.validation.is_fully_connected()
-        if tx_meta.voided_by is None:
-            tx_meta.voided_by = set()
-        tx_meta.voided_by.add(settings.PARTIALLY_VALIDATED_ID)
+        tx_meta.add_voided_by(settings.PARTIALLY_VALIDATED_ID)
 
     def unmark_partially_validated(self) -> None:
         """ This function is used to remove the partially-validated mark from the voided-by metadata.
@@ -574,10 +572,7 @@ def unmark_partially_validated(self) -> None:
         """
         tx_meta = self.get_metadata()
         assert tx_meta.validation.is_fully_connected()
-        if tx_meta.voided_by is not None:
-            tx_meta.voided_by.discard(settings.PARTIALLY_VALIDATED_ID)
-            if not tx_meta.voided_by:
-                tx_meta.voided_by = None
+        tx_meta.del_voided_by(settings.PARTIALLY_VALIDATED_ID)
 
     @abstractmethod
     def verify_checkpoint(self, checkpoints: List[Checkpoint]) -> None:

hathor/transaction/transaction_metadata.py

@@ -360,6 +360,13 @@ def add_voided_by(self, item: bytes) -> None:
         else:
             self.voided_by.add(item)
 
+    def del_voided_by(self, item: bytes) -> None:
+        """Deletes `item` from `self.voided_by`. Note that this method does not save the change."""
+        if self.voided_by is not None:
+            self.voided_by.discard(item)
+            if not self.voided_by:
+                self.voided_by = None
+
     def get_soft_height(self) -> int:
         """ Returns the soft-height, which is either the soft_height or height metadata.