feat: enable cache by default

Author: glevco

hathor/builder/cli_builder.py

@@ -150,7 +150,7 @@ def create_manager(self, reactor: Reactor) -> HathorManager:
                 indexes = RocksDBIndexesManager(self.rocksdb_storage)
 
             kwargs: dict[str, Any] = {}
-            if not self._args.cache:
+            if self._args.disable_cache:
                 # We should only pass indexes if cache is disabled. Otherwise,
                 # only TransactionCacheStorage should have indexes.
                 kwargs['indexes'] = indexes
@@ -162,7 +162,8 @@ def create_manager(self, reactor: Reactor) -> HathorManager:
 
         self.log.info('with storage', storage_class=type(tx_storage).__name__, path=self._args.data)
         if self._args.cache:
-            self.check_or_raise(not self._args.memory_storage, '--cache should not be used with --memory-storage')
+            self.log.warn('--cache is now the default and will be removed')
+        if not self._args.disable_cache and not self._args.memory_storage:
             tx_storage = TransactionCacheStorage(tx_storage, reactor, indexes=indexes, settings=settings)
             if self._args.cache_size:
                 tx_storage.capacity = self._args.cache_size

hathor/cli/run_node.py

@@ -29,6 +29,8 @@
     from hathor.cli.run_node_args import RunNodeArgs
     from hathor.sysctl.runner import SysctlRunner
 
+DEFAULT_CACHE_SIZE: int = 100000
+
 
 @contextmanager
 def temp_fifo(filename: str, tempdir: str | None) -> Iterator[None]:
@@ -116,8 +118,11 @@ def create_parser(cls) -> ArgumentParser:
         parser.add_argument('--prometheus', action='store_true', help='Send metric data to Prometheus')
         parser.add_argument('--prometheus-prefix', default='',
                             help='A prefix that will be added in all Prometheus metrics')
-        parser.add_argument('--cache', action='store_true', help='Use cache for tx storage')
-        parser.add_argument('--cache-size', type=int, help='Number of txs to keep on cache')
+        cache_args = parser.add_mutually_exclusive_group()
+        cache_args.add_argument('--cache', action='store_true', help=SUPPRESS)  # moved to --disable-cache
+        cache_args.add_argument('--disable-cache', action='store_false', help='Disable cache for tx storage')
+        parser.add_argument('--cache-size', type=int, help='Number of txs to keep on cache',
+                            default=DEFAULT_CACHE_SIZE)
         parser.add_argument('--cache-interval', type=int, help='Cache flush interval')
         parser.add_argument('--recursion-limit', type=int, help='Set python recursion limit')
         parser.add_argument('--allow-mining-without-peers', action='store_true', help='Allow mining without peers')

hathor/cli/run_node_args.py

@@ -52,6 +52,7 @@ class RunNodeArgs(BaseModel, extra=Extra.allow):
     prometheus: bool
     prometheus_prefix: str
     cache: bool
+    disable_cache: bool
     cache_size: Optional[int]
     cache_interval: Optional[int]
     recursion_limit: Optional[int]