review changes

Author: msbrogli

hathor/p2p/sync_v2/agent.py

@@ -947,6 +947,7 @@ def handle_transaction(self, payload: str) -> None:
             self.log.warn('not a transaction', hash=tx.hash_hex)
             # Not a transaction. Punish peer?
             return
+        tx.storage = self.tx_storage
 
         assert self._tx_streaming_client is not None
         self._tx_streaming_client.handle_transaction(tx)

hathor/p2p/sync_v2/blockchain_streaming_client.py

@@ -93,7 +93,9 @@ def handle_blocks(self, blk: Block) -> None:
             self.fails(TooManyVerticesReceivedError())
             return
 
-        # Run basic verification.
+        # TODO Run basic verification. We will uncomment these lines after we finish
+        # refactoring our verification services.
+        #
         # if not blk.is_genesis:
         #     try:
         #         self.manager.verification_service.validate_basic(blk)

hathor/p2p/sync_v2/exception.py

@@ -18,12 +18,12 @@ class StreamingError(Exception):
 
 
 class TooManyVerticesReceivedError(StreamingError):
-    """Raised when the other peer sent too many vertices."""
+    """Raised when the other peer has sent too many vertices."""
     pass
 
 
 class TooManyRepeatedVerticesError(StreamingError):
-    """Raised when the other peer sent too many repeated vertices."""
+    """Raised when the other peer has sent too many repeated vertices."""
     pass
 
 
@@ -38,4 +38,5 @@ class InvalidVertexError(StreamingError):
 
 
 class UnexpectedVertex(StreamingError):
+    """Raised when we are not expecting the received vertex."""
     pass

hathor/p2p/sync_v2/streamers.py

@@ -216,7 +216,9 @@ def __init__(self,
         assert isinstance(self.first_block, Block)
         assert isinstance(self.last_block, Block)
 
-        # TODO Validated start_from and use it when it's not empty.
+        # Validate that all transactions in `start_from` are confirmed by the first block.
+        for tx in start_from:
+            assert tx.get_metadata().first_block == first_block_hash
 
         self.current_block: Optional[Block] = self.first_block
         self.bfs = BFSOrderWalk(self.tx_storage, is_dag_verifications=True, is_dag_funds=True, is_left_to_right=False)

hathor/p2p/sync_v2/transaction_streaming_client.py

@@ -25,7 +25,7 @@
 )
 from hathor.p2p.sync_v2.streamers import DEFAULT_STREAMING_LIMIT, StreamEnd
 from hathor.transaction import BaseTransaction
-from hathor.transaction.exceptions import HathorError
+from hathor.transaction.exceptions import HathorError, TxValidationError
 from hathor.types import VertexId
 
 if TYPE_CHECKING:
@@ -93,12 +93,12 @@ def handle_transaction(self, tx: BaseTransaction) -> None:
         self.log.debug('tx received', tx_id=tx.hash.hex())
 
         # Run basic verification.
-        # if not tx.is_genesis:
-        #     try:
-        #         self.manager.verification_service.validate_basic(tx)
-        #     except TxValidationError as e:
-        #         self.fails(InvalidVertexError(repr(e)))
-        #         return
+        if not tx.is_genesis:
+            try:
+                self.manager.verification_service.validate_basic(tx)
+            except TxValidationError as e:
+                self.fails(InvalidVertexError(repr(e)))
+                return
 
         # Any repeated transaction will fail this check because they will
         # not belong to the waiting list.